Chris Jerdonek chris.jerdo...@gmail.com added the comment:
Thanks, Senthil. I would prefer if you created a new issue in the tracker for
your additional changes, and then committed your changes as part of that issue.
By attribution, I was referencing the Patch by Chris Jerdonek which can go
Senthil Kumaran sent...@uthcode.com added the comment:
Hi Chris, your patch looks good. I shall commit it now. The rest of the
documentation changes can go in another patch. Thanks!
--
___
Python tracker rep...@bugs.python.org
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset f6ce142c2fce by Senthil Kumaran in branch '3.2':
- Issue #15250: Document that filecmp.dircmp compares files shallowly. Patch
contributed by Chris Jerdonek.
http://hg.python.org/cpython/rev/f6ce142c2fce
New
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 3921d3c71e64 by Senthil Kumaran in branch '2.7':
Issue #15250: Document that filecmp.dircmp compares files shallowly. Patch
contributed by Chris Jerdonek.
http://hg.python.org/cpython/rev/3921d3c71e64
--
Senthil Kumaran sent...@uthcode.com added the comment:
This is taken care. Rest of documentation improvements could be dealt with in
Issue15430. Thanks, Chris.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
Chris Jerdonek chris.jerdo...@gmail.com added the comment:
Thanks a lot for committing this for me Senthil. And thanks also for creating
a separate issue for the other changes. I appreciate it.
--
___
Python tracker rep...@bugs.python.org
Senthil Kumaran sent...@uthcode.com added the comment:
Thanks for this report. I saw that filecmp.rst could be improved a bit further
too. I added some additional improvements to the docs in addition to the one
you mentioned in the patch.
--
assignee: docs@python - orsenthil
nosy:
Chris Jerdonek chris.jerdo...@gmail.com added the comment:
For attribution purposes and to keep the issue focused, shouldn't those other
changes be added as part of a separate issue?
The changes you added are much larger than mine, and address cosmetic issues
and other issues unrelated to the
Senthil Kumaran sent...@uthcode.com added the comment:
If by attribution, if you mean, proper mention of credits/ acks, during the
commit, I shall add it. Also, I agree that shallow should be documented.
But there were few more places which were lacking, so I ended up with
expanding docs after
Changes by Chris Jerdonek chris.jerdo...@gmail.com:
--
keywords: +patch
stage: needs patch - patch review
Added file: http://bugs.python.org/file26265/issue15250-1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15250
New submission from Chris Jerdonek chris.jerdo...@gmail.com:
The documentation for the dircmp class doesn't say that the same_files and
diff_files attributes are determined using the shallow=True rules described
in the filecmp.cmp() and filecmp.cmpfiles(). It should say this.
For example,
Changes by Éric Araujo mer...@netwok.org:
--
stage: - needs patch
versions: +Python 2.7, Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15250
___
12 matches
Mail list logo
