[issue15269] Document dircmp.left and dircmp.right

R. David Murray added the comment: Thanks, Chris. -- nosy: +r.david.murray resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue15269] Document dircmp.left and dircmp.right

Roundup Robot added the comment: New changeset 7590dec388a7 by R David Murray in branch '3.2': #15269: document dircmp.left and right, and add tests for them. http://hg.python.org/cpython/rev/7590dec388a7 New changeset c592e5a8fa4f by R David Murray in branch 'default': Merge #15269: document di

[issue15269] Document dircmp.left and dircmp.right

Chris Jerdonek added the comment: Senthil, here is a recent e-mail and response in which I asked about documentation changes and adding tests during feature freeze: http://mail.python.org/pipermail/python-dev/2012-July/121138.html Also, here is a recent example of a documentation clarification

[issue15269] Document dircmp.left and dircmp.right

Chris Jerdonek added the comment: Thanks a lot, Senthil. I appreciate it. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue15269] Document dircmp.left and dircmp.right

Senthil Kumaran added the comment: As this is not adding any feature, but just an additional clarification to the existing attribute together with some useful documentation, I believe this can go in 2.7, 3.2 and 3.3 Please correct me if I am wrong here. -- versions: +Python 2.7, Pytho

[issue15269] Document dircmp.left and dircmp.right

Senthil Kumaran added the comment: Hi Chris & Eli, - Sorry that I missed this issue. Chris - agree to your rationale. I can see how having self.left and self.right documented can add value, The diff example was useful. Initially, I did have some doubts in terms how it could be useful when the

[issue15269] Document dircmp.left and dircmp.right

Changes by Chris Jerdonek : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue15269] Document dircmp.left and dircmp.right

Chris Jerdonek added the comment: Sounds good. And for the record, new issue created here: issue 15454 -- ___ Python tracker ___ ___

[issue15269] Document dircmp.left and dircmp.right

Eli Bendersky added the comment: I think it can go into 3.3 but only if it gets reviewed by another core dev (we're in release candidate stage now). Senthil - can you review the patch together with me? As for customizing the stream, yes, go ahead and open a new issue for it, and add me there

[issue15269] Document dircmp.left and dircmp.right

Chris Jerdonek added the comment: Attaching a patch to address Eli's requests (1) and (2). Since this patch merely adds documentation and tests for existing functionality, is there any reason why this cannot go into Python 3.3? Thanks. -- Added file: http://bugs.python.org/file26516/

[issue15269] Document dircmp.left and dircmp.right

Chris Jerdonek added the comment: Thanks a lot, Eli, and for the suggestions. I would be happy to prepare a full patch. Regarding the stream argument, I think there are other changes to dircmp that would be more useful (e.g. issue 12932), but I agree that some form of your suggestion makes

[issue15269] Document dircmp.left and dircmp.right

Eli Bendersky added the comment: Makes sense. I agree that publicly exposing the left/right attributes makes sense. But let's do it properly: 1. Add an example to the documentation 2. Add some tests to Lib/test/test_filecmp.py that verify these attributes behave as expected In addition, I th

[issue15269] Document dircmp.left and dircmp.right

Chris Jerdonek added the comment: Thanks for taking the time to look at this, Eli. In response to your question, here is one illustrated rationale. When recursing through a directory using dircmp, it is simplest and cleanest to be able to recurse on the subdirs attribute without having to pas

[issue15269] Document dircmp.left and dircmp.right

Eli Bendersky added the comment: Yes, code samples would help clarifying the rationale for this request -- nosy: +eli.bendersky versions: +Python 3.4 -Python 3.3 ___ Python tracker

[issue15269] Document dircmp.left and dircmp.right

Chris Jerdonek added the comment: > Given that we have self.left_list and self.left_only ( and self.right_list > and self.right_only), I am not sure how adding self.left/self.right is going > to add more meaning? It adds more meaning because you can't construct self.left and self.right from

[issue15269] Document dircmp.left and dircmp.right

Senthil Kumaran added the comment: Given that we have self.left_list and self.left_only ( and self.right_list and self.right_only), I am not sure how adding self.left/self.right is going to add more meaning? It would simply point to the dir1 and dir2 arguments that are being passed. Also, i

[issue15269] Document dircmp.left and dircmp.right

Changes by Chris Jerdonek : -- keywords: +patch Added file: http://bugs.python.org/file26282/issue-15269-1.patch ___ Python tracker ___ __

[issue15269] Document dircmp.left and dircmp.right

New submission from Chris Jerdonek : The documentation for the filecmp.dircmp class doesn't mention dircmp.left and dircmp.right. Being aware of this up front would make certain simplifications easier to think of. For example, knowing about these attributes opens up the possibility of passin