[issue1529353] Squeezer - squeeze large output in the interpreter

Tal Einat added the comment: I'm back to working on this. I've made good progress: I'm nearly done with all of the changes suggested here and ready for another PR review. I'd like some opinions on a few things: 1. Should the tooltip-related configuration options be removed? There is one

[issue1529353] Squeezer - squeeze large output in the interpreter

Terry J. Reedy added the comment: 3. It is idlelib's TextView, not tkTextView. If it is not 'good enough', we might improve it. 5. Look at former extensions, like codecontext.py, corresponding parts of editor.py. The key thing for immediate effect is the class reload method, called when

[issue1529353] Squeezer - squeeze large output in the interpreter

Tal Einat added the comment: Additional feature discussion: > 10. The button for 'a'*1 says '(nn lines)'. It should say '(1 > chars)' or '(1 line, 1 chars)'. IMO that's too much, it leads to "information overload". Since the number of lines shown is the number of "wrapped"

[issue1529353] Squeezer - squeeze large output in the interpreter

Tal Einat added the comment: Once the ToolTip is ready, I'll begin working on this. Summarizing what appear to be agreed-upon changes to be made (keeping original numbering for reference): 1. Avoid expanding large output accidentally / too easily. Current suggestions are expanding part of

[issue1529353] Squeezer - squeeze large output in the interpreter

Cheryl Sabella added the comment: 6. Sorry about being so vague. I was referring to the configuration page having an option to hide/show the tooltip. I wasn't sure if that was a necessary config option. -- ___ Python tracker

[issue1529353] Squeezer - squeeze large output in the interpreter

Terry J. Reedy added the comment: 11. Right click should bring up a custom context menu. It can have 'cut' (delete), 'copy' (to clipboard, eliminating middle click need), 'edit' (IDLE editor if it seems ok), 'view' (ditto for TextView). Is there a standard for simulating left and right

[issue1529353] Squeezer - squeeze large output in the interpreter

Terry J. Reedy added the comment: Thanks, Cheryl, very helpful. I have since played around with the patch. Some context first. I want to make improving Shell a major focus for a while. Part of that is handling problematic output. One solution is to remove it. For instance, if I enter a

[issue1529353] Squeezer - squeeze large output in the interpreter

Tal Einat added the comment: Cheryl, thanks for testing this and writing up your thoughts! There is certainly much room for improvement. Since it seems that you and Terry like the approach, I'll start working on the tooltips as Terry asked, and wait for more input from him before beginning

[issue1529353] Squeezer - squeeze large output in the interpreter

Cheryl Sabella added the comment: Thanks for the PR, Tal. I've started looking at it and I have just a few initial observations: 1. Serhiy's msg211068 still happens. I tried his example of print('a'*100). There was a noticeable delay before the button was created, then a button

[issue1529353] Squeezer - squeeze large output in the interpreter

Terry J. Reedy added the comment: Cheryl, if you have time to try out PR 7626, I am curious what you think, as a user. A short doc draft is 2 posts above. -- nosy: +cheryl.sabella ___ Python tracker

[issue1529353] Squeezer - squeeze large output in the interpreter

Terry J. Reedy added the comment: Since this is the sort of addition that I want to test and evaluate in extended use before release, this is a good time to revive this. 3.6.6rc1 and 3.7.0rc1 are due tonight. 3.6.7 and 3.7.1 will be open for patches by tomorrow. I opened #33839 to redoing

[issue1529353] Squeezer - squeeze large output in the interpreter

Tal Einat added the comment: Thanks for the warm welcome, Terry :) > 3.5 only gets security fixes. Yup, my mistake. > 'Large text' has two meanings: long lines and lots of lines. [...] Squeezer handles both long lines and/or large numbers of lines. > As the comment at the top of

[issue1529353] Squeezer - squeeze large output in the interpreter

Terry J. Reedy added the comment: Last fall, we converted built-in 'extensions' to regular features. I am reluctant to add new 'extensions'. But I can review the patch as an extension before we worry about this. -- ___ Python tracker

[issue1529353] Squeezer - squeeze large output in the interpreter

Terry J. Reedy added the comment: Tal, welcome back to Python and IDLE development. 3.5 only gets security fixes. Please post here a draft doc paragraph. Before reading the code in detail, I will pull it into my repository and try to test it as a 'naive user' who has only read that

[issue1529353] Squeezer - squeeze large output in the interpreter

Tal Einat added the comment: New PR ready for review. I've updated the code for recent master and cleaned up the deprecation warnings from the tests. -- versions: +Python 3.5, Python 3.6, Python 3.7, Python 3.8 -Python 3.4 ___ Python tracker

[issue1529353] Squeezer - squeeze large output in the interpreter

Change by Tal Einat : -- pull_requests: +7245 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue1529353] Squeezer - squeeze large output in the interpreter

Tal Einat added the comment: See msg212020 for a Python-style explanation of the utility of the Squeezer extension. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1529353 ___

[issue1529353] Squeezer - squeeze large output in the interpreter

Tal Einat added the comment: Added screenshot of what working with the IDLE shell with the Squeezer extension looks like (on Windows). Note that the second squeezed text is the very long Max recursion depth exception traceback, which I manually squeezed after it was printed. -- Added

[issue1529353] Squeezer - squeeze large output in the interpreter

Tal Einat added the comment: Serhiy, which warnings? Some of the tests use Tk GUI elements, so they include requires('gui'). You need to run the tests with a proper environment so that these tests are run; otherwise you get a warning that the 'gui' resource in unavailable. --

[issue1529353] Squeezer - squeeze large output in the interpreter

Tal Einat added the comment: See related issue6143 IDLE - an extension to clear the shell window, where special support for Squeezer is required in that extension (patch included there). -- ___ Python tracker rep...@bugs.python.org

[issue1529353] Squeezer - squeeze large output in the interpreter

Serhiy Storchaka added the comment: The test emits a lot of warnings. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1529353 ___ ___

[issue1529353] Squeezer - squeeze large output in the interpreter

Serhiy Storchaka added the comment: Mainly deprecation warnings about assertEquals(). Run ./python -Wall -b -m test.regrtest -vuall test_idle -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1529353

[issue1529353] Squeezer - squeeze large output in the interpreter

Changes by Tal Einat talei...@gmail.com: -- nosy: +roger.serwy, terry.reedy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1529353 ___ ___

[issue1529353] Squeezer - squeeze large output in the interpreter

Serhiy Storchaka added the comment: Expanded text still makes IDLE unresponsible. Try print('a'*1000). I think it will be better to output first 100 lines and a button More, pressing on which expands next 100 lines. -- ___ Python tracker

[issue1529353] Squeezer - squeeze large output in the interpreter

Serhiy Storchaka added the comment: During experiments I got following message on terminal: Exception in Tkinter callback Traceback (most recent call last): File /home/serhiy/py/cpython/Lib/tkinter/__init__.py, line 1482, in __call__ return self.func(*args) File

[issue1529353] Squeezer - squeeze large output in the interpreter

Tal Einat added the comment: Regarding the tooltip traceback, seems like that could be related. I added a tooltip to the squeezed text buttons, with no delay, so perhaps there's some kind of race condition? Could you try changing delay=0 in the code to delay=50 and see if the issue goes

[issue1529353] Squeezer - squeeze large output in the interpreter

Serhiy Storchaka added the comment: I'm not able to reproduce the problem after the first time (even with delay=0). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1529353 ___

[issue1529353] Squeezer - squeeze large output in the interpreter

Tal Einat added the comment: Indeed, expanding very long texts still degrades the performance of IDLE. But the user has to explicitly expand the text (by double-clicking the button) and can easily squeeze the text again. As for your suggestion to show just the first several lines and a

[issue1529353] Squeezer - squeeze large output in the interpreter

Tal Einat added the comment: Here's a completely re-written patch! The patch is against current 3.3 (changeset 360976a6d8b9), since that's what Terry requested recently on issue3068. It also applies cleanly to the current default branch (changeset 360976a6d8b9). This patch has cleaner,

[issue1529353] Squeezer - squeeze large output in the interpreter

Tal Einat added the comment: Ping? Can this please go in? It's such a great improvement to user experience! I've seen too many novice users print a ton of output by accident and have IDLE hang as a result, losing their interactive session. This simple extension avoid those issues completely,

[issue1529353] Squeezer - squeeze large output in the interpreter

Serhiy Storchaka added the comment: Could you please provide a patch which applies to default branch? There is other proposed solution for the problem of large output: issue1442493. -- stage: patch review - needs patch ___ Python tracker

[issue1529353] Squeezer - squeeze large output in the interpreter

Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: +serhiy.storchaka versions: +Python 3.4 -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1529353 ___

[issue1529353] Squeezer - squeeze large output in the interpreter

Changes by Mark Lawrence breamore...@yahoo.co.uk: -- versions: +Python 3.2 -Python 2.7, Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1529353 ___

[issue1529353] Squeezer - squeeze large output in the interpreter

Tal Einat talei...@users.sourceforge.net added the comment: Test needed? I'll need a bit of guidance on this. Has there been a change of policy of which I'm not aware, that patches to IDLE not going to be accepted unless comprehensive tests are included? Much of IDLE doesn't include tests,

[issue1529353] Squeezer - squeeze large output in the interpreter

Daniel Diniz aja...@gmail.com added the comment: Tal, There is no such policy AFAIK. The stage field is a tool to help us handle the issues, sorry to give you a wrong impression. If IDLE has no tests, 'test needed' doesn't apply here, so we can set this to 'patch review'. If someone is already

[issue1529353] Squeezer - squeeze large output in the interpreter

Tal Einat talei...@users.sourceforge.net added the comment: Daniel, Thanks for clearing that up :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1529353 ___

[issue1529353] Squeezer - squeeze large output in the interpreter

Changes by Christian Heimes: -- assignee: - kbk versions: +Python 2.6 _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1529353 _ ___ Python-bugs-list mailing list