[issue15390] PEP 3121, 384 refactoring applied to datetime module

2018-07-05 Thread Paul Ganssle
Change by Paul Ganssle : -- nosy: +p-ganssle ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue15390] PEP 3121, 384 refactoring applied to datetime module

2016-09-10 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- assignee: belopolsky -> versions: +Python 3.7 -Python 3.4 ___ Python tracker ___ ___ Python-bugs

[issue15390] PEP 3121, 384 refactoring applied to datetime module

2012-12-10 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 10.12.2012 11:39, Robin Schreiber wrote: > > Robin Schreiber added the comment: > > I have updated the patch to work again with the current version of the > _datetimemodule. Please use "_Py_" prefixes for private symbols you put in the header files, e

[issue15390] PEP 3121, 384 refactoring applied to datetime module

2012-12-10 Thread Robin Schreiber
Robin Schreiber added the comment: I have updated the patch to work again with the current version of the _datetimemodule. Regarding the suggestion of separating PEP3121 and PEP384. It might be true that datetime and other modules do not benefit directly from PEP 384, however it is still a f

[issue15390] PEP 3121, 384 refactoring applied to datetime module

2012-11-08 Thread Robin Schreiber
Changes by Robin Schreiber : -- keywords: +pep3121 -patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue15390] PEP 3121, 384 refactoring applied to datetime module

2012-09-10 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: I would like to split this issue to separate PEP 3121 changes from PEP 384. PEP 3121 state cleanup implementation is clearly an improvement "from a resource management point of view." On the other hand, I don't see much benefit for the datetime module

[issue15390] PEP 3121, 384 refactoring applied to datetime module

2012-09-09 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: For some reason there are no review links, so I'll review in this message. Include/datetime.h +typedef struct { .. +} _datetimemodulestate; Names exposed in public headers (datetime.h is a public header) should start with Py or _Py. Other offenders incl

[issue15390] PEP 3121, 384 refactoring applied to datetime module

2012-08-26 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- assignee: -> belopolsky ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue15390] PEP 3121, 384 refactoring applied to datetime module

2012-08-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: > However we have yet to find a solution for the decref inside the dealloc > methods. Perhaps ask for advice on python-dev? -- ___ Python tracker

[issue15390] PEP 3121, 384 refactoring applied to datetime module

2012-08-15 Thread Robin Schreiber
Robin Schreiber added the comment: I have now included the changes that Antoine suggested. The _Get_State was used for debugging purposes and is, as I think, no longer necessary. However we have yet to find a solution for the decref inside the dealloc methods. -- Added file: http://b

[issue15390] PEP 3121, 384 refactoring applied to datetime module

2012-08-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: +Py_CLEAR(_datetimemodulestate(m)->PyDateTime_DateTimeType); +Py_CLEAR(_datetimemodulestate(m)->PyDateTime_DeltaType); +Py_CLEAR(_datetimemodulestate(m)->PyDateTime_TimeType); +Py_CLEAR(_datetimemodulestate(m)->PyDateTime_TimeZoneType); +Py_CL

[issue15390] PEP 3121, 384 refactoring applied to datetime module

2012-08-14 Thread Andrew Svetlov
Andrew Svetlov added the comment: Add Alexander Belopolsky to nosy list as maintainer of datetime module. -- nosy: +belopolsky ___ Python tracker ___

[issue15390] PEP 3121, 384 refactoring applied to datetime module

2012-08-14 Thread Robin Schreiber
Robin Schreiber added the comment: Fixed _dealloc methods. Also: Init now returns the previously initialized module if available. -- Added file: http://bugs.python.org/file26803/_datetimemodule_pep3121-384_v1.patch ___ Python tracker

[issue15390] PEP 3121, 384 refactoring applied to datetime module

2012-07-22 Thread Andrew Svetlov
Andrew Svetlov added the comment: Too late for 3.3 -- nosy: +asvetlov versions: +Python 3.4 -Python 3.3 ___ Python tracker ___ ___ Py

[issue15390] PEP 3121, 384 refactoring applied to datetime module

2012-07-18 Thread Robin Schreiber
New submission from Robin Schreiber : Changes proposed in PEP3121 and PEP384 have now been applied to the datetime module! -- components: Extension Modules files: _datetimemodule_pep3121-384_v0.patch keywords: patch messages: 165805 nosy: Robin.Schreiber priority: normal severity: norma