[issue15403] Refactor package creation support code into a common location

STINNER Victor added the comment: This issue is 7 years old and has patches: it is no newcomer friendly, I remove the "easy" keyword. -- keywords: -easy nosy: +vstinner ___ Python tracker

[issue15403] Refactor package creation support code into a common location

Changes by Nick Coghlan ncogh...@gmail.com: -- assignee: ncoghlan - ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15403 ___ ___ Python-bugs-list

[issue15403] Refactor package creation support code into a common location

Nick Coghlan added the comment: I took a look at this last night, and found the combination of moving stuff around *and* refactoring it at the same time was too hard to review. So, once the PEP 451 changes for runpy are done, I think it would make more sense to tackle this as at least three

[issue15403] Refactor package creation support code into a common location

Nick Coghlan added the comment: As noted in #18576 and #18578, I'd like for these relocation patches to include the addition of documentation for the submodule in Doc/library/test.rst -- ___ Python tracker rep...@bugs.python.org

[issue15403] Refactor package creation support code into a common location

Nick Coghlan added the comment: Also, now that test.support is a subpackage, the helper should be a submodule of that (test.support.package_helper) rather than directly in the test directory. -- ___ Python tracker rep...@bugs.python.org

[issue15403] Refactor package creation support code into a common location

Indra Talip added the comment: updated patch to apply on top of patch from issue15494 -- nosy: +italip Added file: http://bugs.python.org/file30870/issue-15403-3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15403

[issue15403] Refactor package creation support code into a common location

Changes by Eric Snow ericsnowcurren...@gmail.com: -- nosy: +eric.snow ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15403 ___ ___ Python-bugs-list

[issue15403] Refactor package creation support code into a common location

Chris Jerdonek added the comment: Attaching an updated patch. Changes include: 1. Cleans up and expands support API to include creating nested directory structures (for use in the filecmp tests, for example). 2. Adds unit tests for the full API (similar to test_support.py). 3. Refactors

[issue15403] Refactor package creation support code into a common location

Changes by Nick Coghlan ncogh...@gmail.com: -- dependencies: +Move test/support.py into a test.support subpackage ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15403 ___

[issue15403] Refactor package creation support code into a common location

Chris Jerdonek added the comment: Lib/test/test_import.py also contains test code that would benefit from this (see for example issue 15425). (Though not all files need to be refactored in a single issue.) -- ___ Python tracker

[issue15403] Refactor package creation support code into a common location

Antoine Pitrou added the comment: Please let's not have something called test.supportlib in addition to test.support. If test.support grows too large we can turn it into a package. -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org

[issue15403] Refactor package creation support code into a common location

Chris Jerdonek added the comment: I feel like it is already too large (it is over 1750 lines), and I did not want to create a third sibling test support module (there is also test/script_helper.py that overlaps with test.support). Do you think that the community would be open to refactoring

[issue15403] Refactor package creation support code into a common location

Antoine Pitrou added the comment: I feel like it is already too large (it is over 1750 lines), and I did not want to create a third sibling test support module (there is also test/script_helper.py that overlaps with test.support). Do you think that the community would be open to refactoring

[issue15403] Refactor package creation support code into a common location

Chris Jerdonek added the comment: At this point, would you advise me to add even more to the existing hodge podge, or to create a third sibling test support module? My patch adds closely related test support functionality. Incidentally, this discussion relates to the point I was getting at

[issue15403] Refactor package creation support code into a common location

Antoine Pitrou added the comment: I don't mind refactoring test support routines in maintenance release. I said it was too late for 3.3 because the beta period is closing; but it could be fine for 3.3.1 ;) As for the way forward, I see three possibilites: 1) put everying in test.support, as a

[issue15403] Refactor package creation support code into a common location

Chris Jerdonek added the comment: Thanks for your thoughts. For the purposes of this patch, I will change to putting the new support functionality in test.support. Going forward, if we could do some of the refactoring for 3.3.1, that would be great. :) I worry that the third option may make

[issue15403] Refactor package creation support code into a common location

Antoine Pitrou added the comment: Are you opposed to (2), or is it simply less favorable? Less favorable, because it produces longer import strings (test.support.some_helper instead of test.some_helper). -- ___ Python tracker rep...@bugs.python.org

[issue15403] Refactor package creation support code into a common location

Chris Jerdonek added the comment: Less favorable, because it produces longer import strings (test.support.some_helper instead of test.some_helper). This can be addressed by exposing the API in __init__.py though (as does, say, the unittest package), no? --

[issue15403] Refactor package creation support code into a common location

Antoine Pitrou added the comment: Le dimanche 29 juillet 2012 à 17:00 +, Chris Jerdonek a écrit : Chris Jerdonek added the comment: Less favorable, because it produces longer import strings (test.support.some_helper instead of test.some_helper). This can be addressed by exposing the

[issue15403] Refactor package creation support code into a common location

Nick Coghlan added the comment: Discoverability is definitely a problem - part of that is a docs issue, since test.support is currently the only one mentioned in the prose docs. One advantage to moving to a support subpackage is that we can lose the helper suffix from the names, while still

[issue15403] Refactor package creation support code into a common location

Chris Jerdonek added the comment: Sounds good. Later today I will create an issue to move test/support.py into a test.support subpackage post-release. We can continue the discussion of how to organize it there. -- ___ Python tracker

[issue15403] Refactor package creation support code into a common location

Chris Jerdonek added the comment: Later today I will create an issue to move test/support.py into a test.support subpackage post-release. I created issue 15494 for this. -- ___ Python tracker rep...@bugs.python.org

[issue15403] Refactor package creation support code into a common location

Chris Jerdonek chris.jerdo...@gmail.com added the comment: It occurs to me that the filecmp/dircmp tests in Lib/test/test_filecmp.py would also benefit from code like this (i.e. being able to create a nested directory of files in one or two lines). And perhaps elsewhere in the tests. This is

[issue15403] Refactor package creation support code into a common location

Changes by Nick Coghlan ncogh...@gmail.com: -- assignee: - ncoghlan ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15403 ___ ___ Python-bugs-list

[issue15403] Refactor package creation support code into a common location

Changes by Éric Araujo mer...@netwok.org: -- nosy: +eric.araujo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15403 ___ ___ Python-bugs-list

[issue15403] Refactor package creation support code into a common location

New submission from Chris Jerdonek chris.jerdo...@gmail.com: This issue addresses the file creation portion of issue 15376, which is to refactor the walk_package support code in test_runpy into a common location. -- components: Tests keywords: easy messages: 165910 nosy: cjerdonek

[issue15403] Refactor package creation support code into a common location

Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- nosy: +ncoghlan ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15403 ___ ___

[issue15403] Refactor package creation support code into a common location

Chris Jerdonek chris.jerdo...@gmail.com added the comment: Attaching patch. -- keywords: +patch Added file: http://bugs.python.org/file26447/issue-15403-1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15403