[issue15417] Add support for csh and fish in venv activation scripts

Changes by Andrew Svetlov : -- assignee: -> asvetlov resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ __

[issue15417] Add support for csh and fish in venv activation scripts

Roundup Robot added the comment: New changeset c519b490f4e4 by Andrew Svetlov in branch 'default': Issue #15417: Add support for csh and fish in venv activation scripts. http://hg.python.org/cpython/rev/c519b490f4e4 -- nosy: +python-dev ___ Python tra

[issue15417] Add support for csh and fish in venv activation scripts

Vinay Sajip added the comment: > inherit from `venv.EnvBuilder` and override `setup_scripts` method > pointing to new directory with desired activators as `path` parameter > for `self.install_scripts(...)`. Yes, that's it. A third party tool would potentially do more than just custom scripts,

[issue15417] Add support for csh and fish in venv activation scripts

Andrew Svetlov added the comment: 1. I agree with you about exclusion from 3.3. 2. Hmm. Good question. For now virtualenv has support for cmd.exe, csh, fish, bash/zsh and PowerShell. I propose to add csh and fish to venv too. If later somebody will push request for adding yet another shell su

[issue15417] Add support for csh and fish in venv activation scripts

Vinay Sajip added the comment: I have no objection in principle to supporting additional shells, but do have the following comments/questions: 1. Georg feels that this is a new feature he doesn't want to add to 3.3. IMO we have to respect his judgement as RM, no matter how trivial the change

[issue15417] Add support for csh and fish in venv activation scripts

Changes by Andrew Svetlov : -- nosy: +carljm, vinay.sajip ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue15417] Add support for csh and fish in venv activation scripts

Andrew Svetlov added the comment: No idea if Doc/using/venv-create.inc should be updated to reflect support of new shells. virtualenv does nothing in own documentation btw. -- ___ Python tracker ___

[issue15417] Add support for csh and fish in venv activation scripts

New submission from Andrew Svetlov : I have added required shell files -- keywords: +needs review, patch Added file: http://bugs.python.org/file26474/issue15417.diff ___ Python tracker _

[issue15417] Add support for csh and fish in venv activation scripts

Changes by Andrew Svetlov : -- components: Library (Lib) nosy: asvetlov priority: normal severity: normal status: open title: Add support for csh and fish in venv activation scripts versions: Python 3.3 ___ Python tracker