[issue15431] Cannot build importlib.h on Windows

Martin v. Löwis added the comment: The last commits should address Amaury's concerns. _freeze_importlib must now be built manually, followed by a build of pythoncore. Interestingly, the builds failed only once. When rebuilding, the builds succeeded as no attempt to build freeze_importlib was m

[issue15431] Cannot build importlib.h on Windows

Roundup Robot added the comment: New changeset deb421baf671 by Martin v. Löwis in branch 'default': Issue #15431: Drop _freeze_importlib from all build configurations, http://hg.python.org/cpython/rev/deb421baf671 -- ___ Python tracker

[issue15431] Cannot build importlib.h on Windows

Roundup Robot added the comment: New changeset 7967cb63e50e by Martin v. Löwis in branch 'default': Issue #15431: Declare PyImport_FrozenModules conditionally on Unix only. http://hg.python.org/cpython/rev/7967cb63e50e -- ___ Python tracker

[issue15431] Cannot build importlib.h on Windows

Antoine Pitrou added the comment: To be clear, the build fails when importlib needs to be frozen again: $ touch Lib/importlib/_bootstrap.py $ make make Modules/_freeze_importlib make[1] : on entre dans le répertoire « /home/antoine/cpython/default » gcc -pthread -c -Wno-unused-result -g -O0 -Wa

[issue15431] Cannot build importlib.h on Windows

Amaury Forgeot d'Arc added the comment: Comments about PyImport_FrozenModules linkage have not been addressed. Now the build is failing on all Unix machines... -- status: closed -> open ___ Python tracker ___

[issue15431] Cannot build importlib.h on Windows

Martin v. Löwis added the comment: Thanks for the patch, committed with slight modifications. -- nosy: +loewis resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue15431] Cannot build importlib.h on Windows

Roundup Robot added the comment: New changeset fe29a657bde9 by Martin v. Löwis in branch 'default': Issue #15431: Add _freeze_importlib project to regenerate importlib.h on Windows. http://hg.python.org/cpython/rev/fe29a657bde9 -- nosy: +python-dev _

[issue15431] Cannot build importlib.h on Windows

Antoine Pitrou added the comment: > I'll wait for an update for the 64 bit issue. I don't think it's necessary, it's a pretty minor issue since the generated bytecode is portable anyway. -- dependencies: -Python/importlib.h is different on 32bit and 64bit nosy: +pitrou _

[issue15431] Cannot build importlib.h on Windows

Amaury Forgeot d'Arc added the comment: (Sorry for the previous message, it was wrong, and I also pressed the wrong button...) A Unix Makefile cannot stand circular dependencies, so _freezeimportlib.c cannot depend on frozen.o. OTOH it's not simple to have almost-similar list of files on VS

[issue15431] Cannot build importlib.h on Windows

Changes by Amaury Forgeot d'Arc : -- Removed message: http://bugs.python.org/msg166584 ___ Python tracker ___ ___ Python-bugs-list mai

[issue15431] Cannot build importlib.h on Windows

Amaury Forgeot d'Arc added the comment: If you look at Makefile.pre.in, you'll see that on Unix it builds a special binary: Modules/_freezeimportlib.c; it uses most of Python machinery (except importlib, of course), and manually open importlib/_bootstrap.py, compiles it, and marshals the res

[issue15431] Cannot build importlib.h on Windows

Kristján Valur Jónsson added the comment: Thank you. I see how I must change the linkage on PC Only, although I wonder why tuen unix version isn't simply doing something similar.. The marshaled code was indeed created using 64 bits. I was unsure whether to include that file as part of the p

[issue15431] Cannot build importlib.h on Windows

Amaury Forgeot d'Arc added the comment: IMO dependencies is not a big issue here. In the worst case, the developer can build a second time... I think your patch won't work on Unix machines: _freeze_importlib.c is linked with all Python files *except* frozen.c which defines PyImport_FrozenMod

[issue15431] Cannot build importlib.h on Windows

Kristján Valur Jónsson added the comment: Here's a patch. A new project, _freeze_importlib, has the necessary prerequisites and runs the executable, generating importlib.h, as a post-build step. I'm not sure if we should make this project a pre-requisite of any other projects, though -

[issue15431] Cannot build importlib.h on Windows

Kristján Valur Jónsson added the comment: shouldn't be too hard to add, I'll give it a go soon. -- ___ Python tracker ___ ___ Python-

[issue15431] Cannot build importlib.h on Windows

Changes by Antoine Pitrou : -- nosy: +kristjan.jonsson, sbt ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue15431] Cannot build importlib.h on Windows

Changes by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue15431] Cannot build importlib.h on Windows

New submission from Amaury Forgeot d'Arc : On Windows, the _freeze_importlib tool is not built, so it's not possible to refresh the file Python/importlib.h, which makes development on the importlib very difficult on Windows. The Makefile contains the rules below, it's probably necessary to imp