[issue1545463] New-style classes fail to cleanup attributes

Changes by Antoine Pitrou : -- assignee: belopolsky -> status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue1545463] New-style classes fail to cleanup attributes

Roundup Robot added the comment: New changeset 8a5bebea9fec by Antoine Pitrou in branch 'default': Issue #1545463: At shutdown, defer finalization of codec modules so that stderr remains usable. http://hg.python.org/cpython/rev/8a5bebea9fec -- ___ Py

[issue1545463] New-style classes fail to cleanup attributes

Antoine Pitrou added the comment: Here is a patch, it seems to work on the custom buildbots. The problem was two-fold: - PyErr_Warn() is too high-level, it will invoke linecache and others - encodings and codecs shouldn't be cleared before the final shutdown -- Added file: http://bugs.p

[issue1545463] New-style classes fail to cleanup attributes

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue1545463] New-style classes fail to cleanup attributes

Antoine Pitrou added the comment: Your diagnosis seems right about test_garbage_at_shudown (I can reproduce under Linux using `PYTHONIOENCODING=iso8859-15 ./python -m test -v test_gc`). -- ___ Python tracker ___

[issue1545463] New-style classes fail to cleanup attributes

Richard Oudkerk added the comment: On Windows my encoding for stdout, stderr is "cp1252" which is implemented in pure python. By the time that _PyGC_DumpShutdownStats() runs the encoding.cp1252 module has been purged so stdout and stderr are broken. I am afraid I will have to leave this to yo

[issue1545463] New-style classes fail to cleanup attributes

Richard Oudkerk added the comment: I will try a fix. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue1545463] New-style classes fail to cleanup attributes

Richard Oudkerk added the comment: I think the problem is that the __del__ method fails on Windows, maybe because sys.stdout and sys.__stderr__ have been replaced by None. Consider the following program: import os class C: def __del__(self, write=os.write): write(1, b"BEFO

[issue1545463] New-style classes fail to cleanup attributes

Antoine Pitrou added the comment: > The test seems to be failing on Windows. Yes. I'll try to setup a new Windows dev environment and take a look :-/ -- ___ Python tracker ___

[issue1545463] New-style classes fail to cleanup attributes

Richard Oudkerk added the comment: The test seems to be failing on Windows. -- nosy: +sbt status: closed -> open ___ Python tracker ___

[issue1545463] New-style classes fail to cleanup attributes

Antoine Pitrou added the comment: This issue is endly fixed in 3.4. Since changing the shutdown sequence is a delicate change, I won't backport to bugfix branches. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed

[issue1545463] New-style classes fail to cleanup attributes

Roundup Robot added the comment: New changeset f0833e6ff2d2 by Antoine Pitrou in branch 'default': Issue #1545463: Global variables caught in reference cycles are now garbage-collected at shutdown. http://hg.python.org/cpython/rev/f0833e6ff2d2 -- nosy: +python-dev _

[issue1545463] New-style classes fail to cleanup attributes

Antoine Pitrou added the comment: Here is an updated patch after the latest changes on default. -- Added file: http://bugs.python.org/file30129/gcshutdown2.patch ___ Python tracker ___

[issue1545463] New-style classes fail to cleanup attributes

Changes by Armin Rigo : -- nosy: -arigo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue1545463] New-style classes fail to cleanup attributes

Antoine Pitrou added the comment: Here is a patch adding a call to gc.collect() after cleaning up most modules, with tests. -- keywords: +patch nosy: +ncoghlan stage: commit review -> patch review type: resource usage -> enhancement versions: +Python 3.4 -Python 3.2 Added file: http://b

[issue1545463] New-style classes fail to cleanup attributes

Changes by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue1545463] New-style classes fail to cleanup attributes

Gregory P. Smith added the comment: looks harmless to me. though i think issue812369 looks okay as well at first glance. -- ___ Python tracker ___ __

[issue1545463] New-style classes fail to cleanup attributes

Alexander Belopolsky added the comment: Does anyone want to weigh in on this? I am merging in the issue812369 nosy list. I would like to either apply gc-import.patch or close this as superseded by issue812369. -- keywords: +needs review -patch nosy: +arigo, brett.cannon, candrea, cb

[issue1545463] New-style classes fail to cleanup attributes

Changes by Facundo Batista : -- versions: -Python 2.5.3 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue1545463] New-style classes fail to cleanup attributes

Alexander Belopolsky added the comment: This is superseded by issue812369, but as a stop-gap measure, I don't see any downside of applying gc-import.patch. -- assignee: -> belopolsky ___ Python tracker ___

[issue1545463] New-style classes fail to cleanup attributes

Mark Lawrence added the comment: Reopened because the history shows comments and patches months after it was set to closed and won't fix, see msg61886. -- nosy: +BreamoreBoy resolution: wont fix -> status: closed -> open ___ Python tracker

[issue1545463] New-style classes fail to cleanup attributes

Changes by Alexander Belopolsky <[EMAIL PROTECTED]>: -- versions: +Python 2.5.3, Python 2.6, Python 2.7 ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue1545463] New-style classes fail to cleanup attributes

Alexander Belopolsky <[EMAIL PROTECTED]> added the comment: amaury> What if PyGC_Collect() is called just before? That would work. With the following patch: === --- Python/import.c (revision 67183) +++ Python/import.c (wor

[issue1545463] New-style classes fail to cleanup attributes

Amaury Forgeot d'Arc added the comment: In PyImport_Cleanup(), sys and __builtin__ are the last ones deleted. What if PyGC_Collect() is called just before? -- nosy: +amaury.forgeotdarc _ Tracker <[EMAIL PROTECTED]>

[issue1545463] New-style classes fail to cleanup attributes

Alexander Belopolsky added the comment: The problem still exists in 2.5.1. The explanations given so far are not correct. With x.py as before (see attached): >>> import sys, gc, x creating X('new') creating X('old') >>> del x,sys.modules['x'] deleting X('old') >>> gc.collect() deleting X('new'

[issue1545463] New-style classes fail to cleanup attributes

Georg Brandl added the comment: In the light of no further results, closing this bug. -- nosy: +georg.brandl resolution: -> wont fix status: open -> closed _ Tracker <[EMAIL PROTECTED]> __