Andrew Svetlov added the comment:
Is it fixed now?
--
nosy: +asvetlov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15539
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
Yes, it's fixed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15539
___
___
Python-bugs-list mailing list
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15539
___
Roundup Robot added the comment:
New changeset f783db4a58ba by Serhiy Storchaka in branch '2.7':
Issue #15539: Fix a number of bugs in Tools/scripts/pindent.py.
http://hg.python.org/cpython/rev/f783db4a58ba
New changeset 9df6b707aef9 by Serhiy Storchaka in branch '3.2':
Issue #15539: Fix a
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15539
Ezio Melotti added the comment:
Some buildbots are failing:
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%202.7/builds/341/steps/test/logs/stdio
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/1263/steps/test/logs/stdio
--
Serhiy Storchaka added the comment:
Here is a patch which should fix creating a backup on Windows. Please test it.
If test_tools passes on Windows then I'll commit the patch, in contrary case
I'll just skip checking of backup on Windows.
--
stage: committed/rejected - patch review
Roundup Robot added the comment:
New changeset 2d0c5f97af48 by Serhiy Storchaka in branch '2.7':
Issue #15539: Fix backup file creation in pindent.py on Windows
http://hg.python.org/cpython/rev/2d0c5f97af48
New changeset a9990104f728 by Serhiy Storchaka in branch '3.2':
Issue #15539: Fix a
Serhiy Storchaka added the comment:
I hope it will help buidbots.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15539
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
If no one objects I will commit this next year.
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15539
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15539
___
___
Serhiy Storchaka added the comment:
Patch updated. Tests added.
I am not sure tests will be passed on Windows.
--
Added file: http://bugs.python.org/file28224/pindent_2.patch
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
5. Fixed one type in help message.
Typo. Should be Fixed one typo in help message.
Patch updated, unused experimental variable removed.
--
Added file: http://bugs.python.org/file26696/pindent.patch
___
Python
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file26665/pindent.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15539
___
Serhiy Storchaka added the comment:
There is now a test_tools, so it would be great to have tests to go along
with this patch.
Well, I'll do it. But the tests most likely will be different for different
versions of Python (in contrast to the pindent patch).
pindent -d and then pindent -c
Changes by Serhiy Storchaka storch...@gmail.com:
--
keywords: +needs review
priority: normal - low
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15539
___
R. David Murray added the comment:
There is now a test_tools, so it would be great to have tests to go along with
this patch.
I haven't looked at the patch in detail, but as long as you are modernizing it
please kill those # end ... lines.
--
nosy: +r.david.murray
New submission from Serhiy Storchaka:
Here is a patch which fixes some bugs in Tools/scripts/pindent.py and
modernizes it with regard to the new Python features abilities that have made
since 1994.
1. Now pindent works with with.
2. Now pindent does not produce improper indentation (tabs by
18 matches
Mail list logo
