[issue1568] PATCH: Armin's attribute lookup caching for 3.0

Antoine Pitrou added the comment: Closing: Neil's algorithm is not different from what is already in 3.2, except for the additional type_attrcache_callback() which probably doesn't make a difference in normal workloads. -- resolution: accepted -> out of date status: open -> closed __

[issue1568] PATCH: Armin's attribute lookup caching for 3.0

Mark Lawrence added the comment: As the patch provides some performance increase which has already been proven to work in 2.6, could we get this into 3.2? I say this because I understand that performance was degraded in py3k, could this be one of the reasons why? -- nosy: +BreamoreBo

[issue1568] PATCH: Armin's attribute lookup caching for 3.0

Antoine Pitrou added the comment: Ok, reopening and retargetting to 3.1 in case someone wants to work on it. -- resolution: fixed -> accepted stage: -> patch review status: closed -> open type: feature request -> performance versions: +Python 3.1 -Python 3.0 __

[issue1568] PATCH: Armin's attribute lookup caching for 3.0

Amaury Forgeot d'Arc added the comment: I'm not sure this should be closed. According to Neil (see above) the implementation could be simpler in 3.0 -- ___ Python tracker ___ __

[issue1568] PATCH: Armin's attribute lookup caching for 3.0

Antoine Pitrou added the comment: This has been merged to py3k a long time ago, hasn't it? -- nosy: +pitrou resolution: -> fixed status: open -> closed ___ Python tracker ___ __

[issue1568] PATCH: Armin's attribute lookup caching for 3.0

Changes by Raymond Hettinger <[EMAIL PROTECTED]>: -- assignee: rhettinger -> ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs

[issue1568] PATCH: Armin's attribute lookup caching for 3.0

Neil Toronto added the comment: There's nothing it tests that standard unit tests don't, so it shouldn't stick around as a unit test. I used it to time different types of attribute lookups and left it in as an optimization aid. The main test groups are '.' access, successful hasattr (returns Tru

[issue1568] PATCH: Armin's attribute lookup caching for 3.0

Amaury Forgeot d'Arc added the comment: Yes, now the test suite runs without problem. The patch also contains a file "fastattr_test_py3k.py". It seems to perform some benchmark, but I'm not sure to understand its output. Is it meant to be added somewhere? Does it make sense to keep it as a unit

[issue1568] PATCH: Armin's attribute lookup caching for 3.0

Neil Toronto added the comment: Well horse pucky. I plum forgot about deletes. I've attached an update that properly clears the cache entry for the deleted attribute for all non-shadowing subclasses. (It was a small change.) Undef'ing ATTRCACHE_SETATTR_INVALIDATES should work now. Re: different

[issue1568] PATCH: Armin's attribute lookup caching for 3.0

Amaury Forgeot d'Arc added the comment: I tried patch python30-attrcache-1.diff (after reverting the changes made to the 2.6 branch). But test_descr fails. The cache update does not handle the case when an attribute is unmasked, as shown in the following code: class A: pass class B(A): pass b=B

[issue1568] PATCH: Armin's attribute lookup caching for 3.0

Georg Brandl added the comment: #1700288's patch has been committed. Leaving this open as a guide to whoever has to merge it to Py3k. -- nosy: +georg.brandl __ Tracker <[EMAIL PROTECTED]>

[issue1568] PATCH: Armin's attribute lookup caching for 3.0

Raymond Hettinger added the comment: Recommend holding-off on applying this one until I've reviewed and applied the Py2.6 version. -- assignee: -> rhettinger nosy: +rhettinger __ Tracker <[EMAIL PROTECTED]>

[issue1568] PATCH: Armin's attribute lookup caching for 3.0

Neil Toronto added the comment: This patch adds the ability to invalidate all of a subclasses' cache entries upon setattr rather than updating just one cache entry. It's not clear which of these is the Right Thing To Do, so I've made it an #ifdef for now. It defaults to updating. Added file: htt

[issue1568] PATCH: Armin's attribute lookup caching for 3.0

Changes by Christian Heimes: -- keywords: +patch, py3k nosy: +tiran priority: -> normal __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list

[issue1568] PATCH: Armin's attribute lookup caching for 3.0

New submission from Neil Toronto: This is a half-port of the patches in #1685986 and #1700288 to Python 3.0. Speedups are about the same as in those patches applied to their respective Python versions for minibenchmarks (included in the patch as fastattr_test_py3k.py): 5%-30% or more depending on