[issue15781] test_threaded_import fails with -j4

Roundup Robot added the comment: New changeset 85070f284fd2 by Antoine Pitrou in branch 'default': Issue #15781: Fix two small race conditions in import's module locking. http://hg.python.org/cpython/rev/85070f284fd2 -- ___ Python tracker

[issue15781] test_threaded_import fails with -j4

Georg Brandl added the comment: Now picked into 3.3.0 release clone as 85070f284fd2. -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue15781] test_threaded_import fails with -j4

Antoine Pitrou added the comment: Looks fixed! -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue15781] test_threaded_import fails with -j4

Roundup Robot added the comment: New changeset 7fa6336e9864 by Antoine Pitrou in branch 'default': Issue #15781: Fix two small race conditions in import's module locking. http://hg.python.org/cpython/rev/7fa6336e9864 -- nosy: +python-dev ___ Python tr

[issue15781] test_threaded_import fails with -j4

Antoine Pitrou added the comment: > I'm getting another error in test_importlib, both with and without > the patch. I can open another issue for that if you think it's > completely unrelated: Please do. Thanks! -- ___ Python tracker

[issue15781] test_threaded_import fails with -j4

Stefan Krah added the comment: Nice, on the finicky i7 machine test_threaded_import is fixed. I'm getting another error in test_importlib, both with and without the patch. I can open another issue for that if you think it's completely unrelated: $ ./python -m test -uall -F test_importlib

[issue15781] test_threaded_import fails with -j4

Georg Brandl added the comment: Sure. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue15781] test_threaded_import fails with -j4

Antoine Pitrou added the comment: If possible I would like to wait for Stefan's confirmation that it fixes the failures for him. -- ___ Python tracker ___ __

[issue15781] test_threaded_import fails with -j4

Georg Brandl added the comment: Looks good to me. Please commit to default and I'll cherry-pick to rc2. -- ___ Python tracker ___ ___

[issue15781] test_threaded_import fails with -j4

Brett Cannon added the comment: Didn't patch it in to evaluate the surrounding code, but otherwise the patch LGTM. -- stage: patch review -> commit review ___ Python tracker ___

[issue15781] test_threaded_import fails with -j4

Antoine Pitrou added the comment: Ok, I can now reproduce with setswitchinterval(). Here is a patch. There was a race between putting the new module in sys.modules and setting its __initializing__ attribute, so now __initializing__ is set before putting the module in sys.modules. Also, there

[issue15781] test_threaded_import fails with -j4

Changes by Christian Heimes : -- nosy: +christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue15781] test_threaded_import fails with -j4

Stefan Krah added the comment: On the i7 machine with hyper-threading the issue occurs since edb9ce3a6c2e. The tests also got slower: 3430d7329a3b: $ time ./python -m test -uall -v test_threaded_import real0m3.195s user0m0.656s sys 0m0.284s edb9ce3a6c2e: $ time ./python -m te

[issue15781] test_threaded_import fails with -j4

Eric Snow added the comment: (sorry, only saw the first couple messages) -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue15781] test_threaded_import fails with -j4

Eric Snow added the comment: So this was a random one-off (hardly even intermittent) failed test that passed on the retry. Ah, threads. Is there an easy way to find all other failures in test_threaded_import in the past, for this and for all buildbots? Do we have information about load duri

[issue15781] test_threaded_import fails with -j4

Stefan Krah added the comment: Oh, and as usual, my machines have all CPUs at 100% load. -- ___ Python tracker ___ ___ Python-bugs-lis

[issue15781] test_threaded_import fails with -j4

Stefan Krah added the comment: I can also reproduce it on the Core 2 machine with a ridiculuously low switch interval: diff --git a/Lib/test/regrtest.py b/Lib/test/regrtest.py --- a/Lib/test/regrtest.py +++ b/Lib/test/regrtest.py @@ -198,6 +198,8 @@ except ImportError: multiprocessing =

[issue15781] test_threaded_import fails with -j4

Nick Coghlan added the comment: Up to 2279 runs without a failure here - yay for elusive hardware specific threading bugs :P I'll leave it running overnight and see what happens. -- ___ Python tracker ___

[issue15781] test_threaded_import fails with -j4

Stefan Krah added the comment: I can only reproduce this on a Core i7. Native OS is Debian Wheezy, also reproduced earlier on a FreeBSD VM hosted on that machine (see msg167989). The machine has 4 physical cores, perhaps we can blame hyper-threading. ;) $ cat /proc/cpuinfo | grep "model name" m

[issue15781] test_threaded_import fails with -j4

Nick Coghlan added the comment: No joy here either - currently at 704 successful runs and counting with Stefan's command line. $ uname -a Linux lancre 3.5.1-1.fc17.x86_64 #1 SMP Thu Aug 9 17:50:43 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux $ cat /proc/cpuinfo | grep "model name" model name

[issue15781] test_threaded_import fails with -j4

Antoine Pitrou added the comment: With $ ./python -m test -uall -F -j16 -v test_threaded_import I couldn't reproduce after 1000 test passes. -- ___ Python tracker ___ ___

[issue15781] test_threaded_import fails with -j4

Stefan Krah added the comment: The buildbot in question uses -j4, and I can reproduce this on Linux with: ./python -m test -uall -F -j4 -v test_threaded_import == FAIL: test_parallel_meta_path (test.test_threaded_import.Thread