[issue16074] Bad error message in os.rename, os.link, and os.symlink

Larry Hastings added the comment: It's fine that we're not fixing this in 3.3, but since this did get fixed in 3.4, I propose dropping 3.3 from the version list and changing the resolution to "fixed". *waves magic wand* -- resolution: wont fix -> fixed stage: needs patch -> committed/

[issue16074] Bad error message in os.rename, os.link, and os.symlink

Georg Brandl added the comment: No change for 3.3. -- resolution: -> wont fix status: open -> closed ___ Python tracker ___ ___ Pytho

[issue16074] Bad error message in os.rename, os.link, and os.symlink

Vajrasky Kok added the comment: Now, that we have fixed this bug in Python 3.4 with this commit http://hg.python.org/cpython/rev/081a9d8ba3c7, what should we do with the bug in Python 3.3? Use my patch (omitting filenames)? Keep the status quo (one filename)? If yes, close this ticket as inva

[issue16074] Bad error message in os.rename, os.link, and os.symlink

Larry Hastings added the comment: I probably should have continued with this issue instead of creating a new issue for it, sorry. But there's a new issue tracking this change, where I propose to add new error-reporting functions that support two filenames. That's happening in #20517. --

[issue16074] Bad error message in os.rename, os.link, and os.symlink

Serhiy Storchaka added the comment: However it is still a bug in 3.3. -- assignee: serhiy.storchaka -> larry ___ Python tracker ___ __

[issue16074] Bad error message in os.rename, os.link, and os.symlink

Larry Hastings added the comment: As release manager, I would be willing to consider this patch. However, as original author of the code in question, I don't like it. Showing zero filenames, while potentially less confusing, is also far less helpful. A better solution would be to show both

[issue16074] Bad error message in os.rename, os.link, and os.symlink

Serhiy Storchaka added the comment: Larry, are you agree with this solution (remove ambiguous filename attribute from OSError raised by functions with two filename arguments)? -- ___ Python tracker ___

[issue16074] Bad error message in os.rename, os.link, and os.symlink

Serhiy Storchaka added the comment: The 3.4 patch LGTM, but the 3.3 patch perhaps has a bug. -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue16074] Bad error message in os.rename, os.link, and os.symlink

Vajrasky Kok added the comment: Jakub Wilk, yeah, I missed that one. Jason Gerard DeRose, thanks for the additional information. Anyway, I already "persuaded" Ruby developers to specialize the message, although it's only for creating symlink. https://bugs.ruby-lang.org/issues/9263 As of Pyth

[issue16074] Bad error message in os.rename, os.link, and os.symlink

Jason Gerard DeRose added the comment: vajrasky, one more errno to consider: [Errno 39] Directory not empty: '/tmp/bar' This is when renaming a directory: src directory exists; dst directory exists and is non-empty. In 3.4 Beta1, this error message now includes the src instead of the dst (fl

[issue16074] Bad error message in os.rename, os.link, and os.symlink

Jakub Wilk added the comment: As far as rename() and link() are concerned, either of the arguments can cause an ENOENT error: os.rename('/dev/foobar', '/dev/barfoo') # fails because /dev/foobar doesn't exist os.rename('/dev/null', '/foo/bar/baz') # fails because /foo/bar doesn't exist --

[issue16074] Bad error message in os.rename, os.link, and os.symlink

Vajrasky Kok added the comment: Is there any possibility this ticket could be committed in Python 3.4? If yes, it would be good because we would have a good foundation for creating better error message in Python 3.5. Anyway, I check Python's competitors' behaviour. Ruby displays both files.

[issue16074] Bad error message in os.rename, os.link, and os.symlink

Vajrasky Kok added the comment: Patch for Python 3.3. It omitted file information for error messages in rename, symlink, and link. I'll create a separate ticket for adding extra file information to these error messages. -- Added file: http://bugs.python.org/file32935/better_error_mes

[issue16074] Bad error message in os.rename, os.link, and os.symlink

Vajrasky Kok added the comment: Here is the patch for Python 3.4. It removed file information for os.rename, os.link, and os.symlink. I agree with Ezio that giving extra information is better but since Python 3.4 is in beta maybe we can defer this to Python 3.5. There are couples of errno

[issue16074] Bad error message in os.rename, os.link, and os.symlink

Changes by Vajrasky Kok : -- title: bad error message in os.rename -> Bad error message in os.rename, os.link, and os.symlink ___ Python tracker ___