[issue1612262] Class Browser doesn't show internal classes

Terry J. Reedy added the comment: I settled on 'transform_children' for the new function. #31461 is the master issue for improving the browsers. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue1612262] Class Browser doesn't show internal classes

Terry J. Reedy added the comment: New changeset fa1cae5832cbcfafedc4b1879c2abc85452f4edd by Terry Jan Reedy in branch '3.6': [3.6] bpo-1612262: IDLE: Class Browser shows nested functions, classes (GH-2573) (#3702)

[issue1612262] Class Browser doesn't show internal classes

Changes by Terry J. Reedy : -- pull_requests: +3686 ___ Python tracker ___ ___

[issue1612262] Class Browser doesn't show internal classes

Terry J. Reedy added the comment: New changeset 058de11360ea6816a6e978c7be0bcbea99a3f7da by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-1612262: IDLE: Class Browser shows nested functions, classes (#2573)

[issue1612262] Class Browser doesn't show internal classes

Terry J. Reedy added the comment: I am revising the codecontext patch to use comprehensions and the sort key option. I will rename the new function 'collect_objects' (GPolo) / '_traverse_node' (CSabella) as 'list_children' and have it return the name-object list, ordered by line number,

[issue1612262] Class Browser doesn't show internal classes

Nick Coghlan added the comment: I think a bundled copy as idlelib._pyclbr in the 3.6 branch would be within the intent of PEP 434. -- ___ Python tracker

[issue1612262] Class Browser doesn't show internal classes

Terry J. Reedy added the comment: Would it make any difference if the module were renamed? and made to only work with IDLE? -- ___ Python tracker ___

[issue1612262] Class Browser doesn't show internal classes

Terry J. Reedy added the comment: Nick, this over-due improvement to IDLE depends on the over-due improvement to pyclbr in 3.7. I would like to backport the IDLE improvement by putting a copy of 3.7 pyclbr in 3.6 idlelib. Do you agree that PEP434 allows this? -- nosy: +ncoghlan

[issue1612262] Class Browser doesn't show internal classes

Changes by Terry J. Reedy : -- dependencies: +IDLE: add docstrings to browser.py stage: test needed -> patch review ___ Python tracker

[issue1612262] Class Browser doesn't show internal classes

Cheryl Sabella added the comment: I added a more complete set of unit tests to the PR. -- ___ Python tracker ___

[issue1612262] Class Browser doesn't show internal classes

Cheryl Sabella added the comment: I created issue 30881 to add docstrings to browser.py to make creating user tests easier. -- ___ Python tracker ___

[issue1612262] Class Browser doesn't show internal classes

Changes by Cheryl Sabella : -- pull_requests: +2644 ___ Python tracker ___ ___

[issue1612262] Class Browser doesn't show internal classes

Terry J. Reedy added the comment: I believe the patch for #6691 will also add detection of nested functions. If so, the IDLE patch must also make use of that new information. If the patch for #6691 is only applied to 3.7, I want to put a temporary copy of the revised pyclbr in 3.6 idlelib,

[issue1612262] Class Browser doesn't show internal classes

Terry J. Reedy added the comment: Class Browser is now a module browser as it includes functions not in classes. I guess pyclbr does this. Enhancing this for current versions would require adding a private copy of enhanced pyclbr to idlelib. -- nosy: +terry.reedy priority: low ->

[issue1612262] Class Browser doesn't show internal classes

Changes by Tal Einat talei...@gmail.com: -- nosy: -taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1612262 ___ ___ Python-bugs-list

[issue1612262] Class Browser doesn't show internal classes

Changes by Mark Lawrence breamore...@yahoo.co.uk: -- versions: +Python 3.2 -Python 2.7, Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1612262 ___

[issue1612262] Class Browser doesn't show internal classes

Guilherme Polo ggp...@gmail.com added the comment: The attached patch adds support for nested objects in pyclbr and also in ClassBrowser. I have yet to find an optimal way to test this on test_pyclbr (I did some things here, none very nice), so you will notice tests are missing on this patch.

[issue1612262] Class Browser doesn't show internal classes

Guilherme Polo ggp...@gmail.com added the comment: I've removed the previous patch from here and attached an updated one on issue6691. Now the patch attached here only contains changes related to idlelib.ClassBrowser. -- dependencies: +Support for nested classes and function for pyclbr

[issue1612262] Class Browser doesn't show internal classes

Changes by Guilherme Polo ggp...@gmail.com: Removed file: http://bugs.python.org/file14699/show_nested_objects.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1612262 ___

[issue1612262] Class Browser doesn't show internal classes

Roger Serwy roger.se...@gmail.com added the comment: The class browser relies on the pyclbr module to scan the code. This module doesn't support classes within classes. Both pyclbr and IDLE's class browser need to be modified. -- nosy: +serwy ___

[issue1612262] Class Browser doesn't show internal classes

Daniel Diniz aja...@gmail.com added the comment: Confirmed on trunk and py3k. -- nosy: +ajaksu2 priority: normal - low stage: - test needed type: - feature request versions: +Python 2.7, Python 3.1 -Python 2.6 ___ Python tracker