Roundup Robot added the comment:
New changeset 4cd620d8c3f6 by R David Murray in branch 'default':
whatsnew: DynanicClassAttribute (#19030), Py_SetStandardStreamEncoding (#16129)
http://hg.python.org/cpython/rev/4cd620d8c3f6
--
___
Python tracker
Nick Coghlan added the comment:
Bastien, did you get a chance to try embedding Python 3.4a4 in Blender yet? If
that works for you, we can mark this one as closed.
--
status: pending - open
___
Python tracker rep...@bugs.python.org
Bastien Montagne added the comment:
Wow… Good thing you remind me that. Just tested it here (linux with ASCII
terminal), works perfectly. Thanks again for all the integration work, Nick!
--
___
Python tracker rep...@bugs.python.org
Nick Coghlan added the comment:
Excellent!
Zachary Ware got the embedding tests running and passing on Windows in issue
19439 (previously they were only executed on *nix systems), so Python 3.4
should resolve this problem on all platforms.
--
status: open - closed
Roundup Robot added the comment:
New changeset 12d7b6171b28 by Nick Coghlan in branch 'default':
Issue #16129: Py_SetStandardStreamEncoding cleanups
http://hg.python.org/cpython/rev/12d7b6171b28
--
___
Python tracker rep...@bugs.python.org
Nick Coghlan added the comment:
I dealt with the comments folks made here and on python-dev regarding the docs
and the limited API, as well as the fact it isn't safe to call PyErr_NoMemory()
when this function fails.
However, I still haven't been able to reproduce the failure seen on the
Nick Coghlan added the comment:
(As expected, the original FreeBSD randomization seed passed here without any
problems)
Before I disabled the test completely, I did a run with full error diffs
enabled.
Here's the FreeBSD log with full diffs:
Stefan Krah added the comment:
A test order problem is indeed unlikely: I ran the tests as the buildbot user
with the same random seed and they passed. Let's blame the buildbot software. ;)
--
___
Python tracker rep...@bugs.python.org
Nick Coghlan added the comment:
Larry - I'm kinda stumped on this one. I'm not sure how to debug the failure on
the buildbots, because, as Victor said, sys.stdout/err having an encoding
attribute of None *isn't* supposed to happen, so the test should be fine as it
stands. And nobody has been
Nick Coghlan added the comment:
Ah, that got it:
LC_ALL=C ./python -m test -W test_capi
= boom :)
And, of course it's a StringIO object at that point...
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16129
Changes by Nick Coghlan ncogh...@gmail.com:
--
nosy: +larry
priority: normal - release blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16129
___
Roundup Robot added the comment:
New changeset 4af20969c592 by Nick Coghlan in branch 'default':
Issue #16129: this should appease the buildbots
http://hg.python.org/cpython/rev/4af20969c592
--
___
Python tracker rep...@bugs.python.org
Nick Coghlan added the comment:
So, does that mean asked the release manager for a ruling is the buildbot
debugging equivalent of threatened it with tech support? :)
--
priority: release blocker - normal
resolution: - fixed
stage: needs patch - committed/rejected
status: open -
Nick Coghlan added the comment:
I added tests to the patch and tweaked a few details. Once the local test run
gives it a clean bill of health, I'll commit it so it will be included in 3.4a4
this weekend and you can check it works with Blender.
--
assignee: - ncoghlan
Roundup Robot added the comment:
New changeset 9cd88b39ef62 by Nick Coghlan in branch 'default':
Issue #16129: Add `Py_SetStandardStreamEncoding`
http://hg.python.org/cpython/rev/9cd88b39ef62
--
nosy: +python-dev
___
Python tracker
Nick Coghlan added the comment:
Putting this to pending for the moment - please try it out with Blender once
3.4a4 is released, and then we'll close it.
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - pending
___
Roundup Robot added the comment:
New changeset 537e13ca7683 by Nick Coghlan in branch 'default':
Issue #16129: Move Py_SetStandardStreamEncoding declaration
http://hg.python.org/cpython/rev/537e13ca7683
--
status: pending - open
___
Python tracker
Bastien Montagne added the comment:
Thanks Nick, we’ll do it for sure. :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16129
___
___
Roundup Robot added the comment:
New changeset 51480f6428a5 by Nick Coghlan in branch 'default':
Skip #16129 test until I debug cross-platform issues
http://hg.python.org/cpython/rev/51480f6428a5
--
___
Python tracker rep...@bugs.python.org
Nick Coghlan added the comment:
Buildbots weren't happy with the test case. I've done two extra commits (one to
turn off the diff limit, then a second one to skip it entirely), so will
hopefully be able to debug it and keep this in for the alpha.
(Larry - FYI, I'll have this test fixed or the
Nick Coghlan added the comment:
According to
http://buildbot.python.org/all/builders/AMD64%20Ubuntu%20LTS%203.x/builds/2716/steps/test/logs/stdio,
output in the subprocess was fine, but for some reason sys.stdout.encoding and
sys.stderr.encoding were None in the test itself o.O
--
Nick Coghlan added the comment:
Antoine pointed out this also needs a :versionadded: tag in the docs.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16129
___
Nick Coghlan added the comment:
So reusing the run command from the buildbot still passed on my system.
I thought using sys.stdout.encoding (etc) would reliably get me the default IO
encoding, but it appears not :(
--
___
Python tracker
Nick Coghlan added the comment:
http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.0%203.x/builds/579/steps/test/logs/stdio
shows the same symptoms
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16129
STINNER Victor added the comment:
You don't want to mention the return value (-1) on error in the doc?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16129
___
Stefan Krah added the comment:
Unfortunately the tests pass when I run them manually. On my FreeBSD
bot thsi may be relevant:
o LC_* is C.
o The filesystem encoding is ascii.
--
nosy: +skrah
___
Python tracker rep...@bugs.python.org
Nick Coghlan added the comment:
On 18 Oct 2013 02:41, STINNER Victor rep...@bugs.python.org wrote:
STINNER Victor added the comment:
You don't want to mention the return value (-1) on error in the doc?
I guess it should explicitly say any non-zero return value indicates an
error rather
Brecht Van Lommel added the comment:
I tested the patch on Windows and can confirm it solves the problem for Blender.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16129
___
Bastien Montagne added the comment:
Updated patch (mostly from Brecht's remarks, removed an obvious bug...)
--
Added file: http://bugs.python.org/file31985/setstdio.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16129
Bastien Montagne added the comment:
No one to check the patch? It’s rather small, should not take much time… And we
really need a solution for this issue, so better to try to get this settled
before 3.4 freeze! ;)
--
___
Python tracker
Bastien Montagne added the comment:
Hi,
Decided to give it a try and implement suggested Py_SetStandardStreamEncoding,
see attached patch.
A quick test with Blender under Linux (with an ASCII console) seems to work OK,
unfortunatly I do not have Windows to test it where it really matters...
Brecht Van Lommel added the comment:
With the language summit passed some time ago, is there now a more clear
picture of how this would fit in the initialisation process?
Any idea of what a proper implementation would look like, or is the message
still to wait?
--
nosy:
Nick Coghlan added the comment:
The gory details of the current startup situation are in PEP 432. However, the
comprehensive solution described in that PEP isn't going to make it into Python
3.4, so a simpler interim fix would be worthwhile.
Since Blender is designed to support building
Campbell Barton added the comment:
patch attached, simply wraps putenv()
--
keywords: +patch
Added file: http://bugs.python.org/file28144/pyos_putenv.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16129
Christian Heimes added the comment:
At first glance your proposed fix looks like an easy hack to get around the
issue. However it's not going to work properly. Embedded Python interpreters
should isolate themselves from the user's environment. When
`Py_IgnoreEnvironmentFlag` is enabled,
Nick Coghlan added the comment:
Claiming this one, mainly because I want people to largely leave the already
hairy initialisation process alone until we get a chance to discuss it at the
language summit next year.
I plan to write up a comprehensive overview of the initialisation sequence
Changes by Andrew Svetlov andrew.svet...@gmail.com:
--
nosy: +asvetlov
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16129
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16129
___
Marc-Andre Lemburg added the comment:
IMHO either of these solutions would be fine.
* have a PyOS_PutEnv() function, gettext has gettext_putenv() to
workaround this problem.
This solution would help in many other cases as well, so adding
such an API would certainly help more than
Campbell Barton added the comment:
Agree PyOS_PutEnv would be good since its not restricted to string encoding and
resolves the problem of not being able to control env vars for an embedded
interpreter in general.
Having ways to change encoding is good too but a bit outside the scope of this
Changes by Antoine Pitrou pit...@free.fr:
--
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16129
___
___
Python-bugs-list
New submission from Campbell Barton:
note, I was asked to report this issue, posted on the py dev mailing list: see
- http://code.activestate.com/lists/python-dev/118015/
---
We've run into an issue recently with blender3d on ms-windows where we
want to enforce the encoding is UTF-8 with the
STINNER Victor added the comment:
See also issue #15216.
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16129
___
___
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +lemburg, loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16129
___
___
Python-bugs-list
44 matches
Mail list logo
