[issue1622] zipfile hangs on certain zip files

New submission from Eric Huss: Creating a ZipFile object with a certain type of zip file can cause it to go into an infinite loop. The problem is the new extra field parsing routine. It unpacks integers as a signed value, which if they are sufficiently large (over 32767), then it will loop fore

[issue1622] zipfile hangs on certain zip files

Changes by Guido van Rossum: -- keywords: +patch nosy: +gvanrossum __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscr

[issue1622] zipfile hangs on certain zip files

Alan McIntyre added the comment: Based on the ZIP spec (I'm using the one here: http://www.pkware.com/documents/casestudies/APPNOTE.TXT), I'm inclined to agree. There's a general note that says "All fields unless otherwise noted are unsigned and stored in Intel low-byte:high-byte, low-word:high-w

[issue1622] zipfile hangs on certain zip files

Eric Huss added the comment: Some of this work has already been done, see issue 1189216. You'll obviously need to keep the CRC unpack as signed because the binascii module uses signed values. Some header values are stored as 0x to denote the value is stored in the 64-bit extended fields

[issue1622] zipfile hangs on certain zip files

Guido van Rossum added the comment: Alan and Eric, can I depend on you two to review each other's code and let me know when you think the patch is ready to be submitted? __ Tracker <[EMAIL PROTECTED]>

[issue1622] zipfile hangs on certain zip files

Alan McIntyre added the comment: Well I can't promise it will be swift, since my winter vacation ended today, but I'll keep on top of it as best I can. :) __ Tracker <[EMAIL PROTECTED]> __

[issue1622] zipfile hangs on certain zip files

Alan McIntyre added the comment: Here's the first draft of a patch (zipfile-unsigned-fixes.diff) that does a few things: - Interpret fields as unsigned unless required (CRC, etc.) - Corrects reading of ZIP files with large archive comments - Replaces hard-coded structure sizes with module-level

[issue1622] zipfile hangs on certain zip files

Eric Huss added the comment: Alan, your changes look good to me, but it is missing my patch in this bug that fixes the sign issue in _decodeExtra. While you're there, you might as well change the other 3 unpack lines to use a capital Q. -Eric __ Tracker <[EMAIL

[issue1622] zipfile hangs on certain zip files

Alan McIntyre added the comment: Thanks for the reminder, Eric; I'll include that and post the updated patch. As a side note, on OS X, running regrtest with -uall or -ulargefile still skips test_zipfile4 for some reason. I'll have a look at that before submitting the next version of the patch a

[issue1622] zipfile hangs on certain zip files

Alan McIntyre added the comment: Currently the extra field data is only parsed when it contains Zip64 extended information. It could probably be broken up into a list of (id, data) pairs at a minimum for all data types, since the spec says that's the structure that "should" be used. I don't k

[issue1622] zipfile hangs on certain zip files

Alan McIntyre added the comment: Here's an updated patch (zipfile-unsigned-fixes2.diff) that contains Eric's fixes. I also changed the structure for the Zip64 extension data to be unsigned. I think this should cover all the deficiencies caused by the improper use of unsigned values. Note: if t

[issue1622] zipfile hangs on certain zip files

Alan McIntyre added the comment: I just noticed that my changes for issue 1526 are included in this patch. Eric, if you have time could you have a look at that issue and see if you think I addressed it properly? If not I can back them out into a separate patch for that issue. _

[issue1622] zipfile hangs on certain zip files

Changes by Jesús Cea Avión: -- nosy: +jcea __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue1622] zipfile hangs on certain zip files

Changes by Christian Heimes: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue1622] zipfile hangs on certain zip files

Sean Reifschneider <[EMAIL PROTECTED]> added the comment: Eric: Can you review the latest version of this patch? -- assignee: -> loewis nosy: +jafo, loewis __ Tracker <[EMAIL PROTECTED]>

[issue1622] zipfile hangs on certain zip files

Eric Huss <[EMAIL PROTECTED]> added the comment: Sorry for the long delay. Yes, the latest patch looks very good to me. -Eric __ Tracker <[EMAIL PROTECTED]> __ ___

[issue1622] zipfile hangs on certain zip files

Alan McIntyre <[EMAIL PROTECTED]> added the comment: Is there anything else that needs to be addressed before this can be committed? At the moment I don't know of anything, just wanted to make sure somebody wasn't waiting on me. As a reminder, issues #1526 and #1746 should be closed if this p

[issue1622] zipfile hangs on certain zip files

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: Alan, it appears that the patch doesn't apply anymore, in r63553. Can you please update it? __ Tracker <[EMAIL PROTECTED]> __

[issue1622] zipfile hangs on certain zip files

Alan McIntyre <[EMAIL PROTECTED]> added the comment: Sure, I'll look at it later today or over the weekend. I should probably break out the parts that apply to other issues and update those patches as well. __ Tracker <[EMAIL PROTECTED]>

[issue1622] zipfile hangs on certain zip files

Changes by Martin v. Löwis <[EMAIL PROTECTED]>: -- priority: normal -> high ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-l

[issue1622] zipfile hangs on certain zip files

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: Thanks for the patch. This is now committed as r64688 -- resolution: -> accepted status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> _