[issue16250] URLError invoked with reason as filename

New submission from Chris Jerdonek: This issue is to fix invocations of URLError so that "reasons" are not passed in for the "filename" argument of the URLError constructor. Ezio found and described this issue when commenting on issue 10836: http://bugs.python.org/issue10836#msg172988 In mo

[issue16250] URLError invoked with reason as filename

Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue16250] URLError invoked with reason as filename

Changes by Ezio Melotti : -- nosy: +ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue16250] URLError invoked with reason as filename

Chris Jerdonek added the comment: > raise URLError('local file error: not on local host') I should also point out that URLError invocations with formats like the above already do occur in Lib/urllib/request.py. For example: raise URLError('ftp error: no host given') exc = URLError('ft

[issue16250] URLError invoked with reason as filename

Chris Jerdonek added the comment: For future reference, this affects 3.2 onwards. It probably makes sense to address this in the same branches in which we plan to address issue 16247 (currently set to 3.3 onwards). -- stage: -> needs patch versions: +Python 3.3 _

[issue16250] URLError invoked with reason as filename

Senthil Kumaran added the comment: This patch fixed these URLError wrong invocation issue and adds some tests for testing those it. I noticed that some of these were in the dead-end of the code, like checking if url is not a str (it is always, unwrap makes it a str if otherwise). Those will

[issue16250] URLError invoked with reason as filename

Roundup Robot added the comment: New changeset 8fb438e7f738 by Senthil Kumaran in branch 'default': Issue #16250: Fix the invocations of URLError which had misplaced filename attribute for exception http://hg.python.org/cpython/rev/8fb438e7f738 -- nosy: +python-dev

[issue16250] URLError invoked with reason as filename

Senthil Kumaran added the comment: This is fixed in 3.4. I shall backport to other branches. -- ___ Python tracker ___ ___ Python-bugs

[issue16250] URLError invoked with reason as filename

Antoine Pitrou added the comment: This broke the Windows 7 buildbot: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/850 -- nosy: +pitrou ___ Python tracker _

[issue16250] URLError invoked with reason as filename

Senthil Kumaran added the comment: The change in 49de26395d1a addresses the buildbot failure. I have given a run again. -- ___ Python tracker ___ ___

[issue16250] URLError invoked with reason as filename

Senthil Kumaran added the comment: The change I had made for fixing the windows buildbot had not fixed it. I am skipped (1f92315d9568) the test on windows, investigating the reason for windows behavior and I shall remove the skiptest on windows after fix. -- _

[issue16250] URLError invoked with reason as filename

Roundup Robot added the comment: New changeset 5e71f2712076 by Senthil Kumaran in branch '3.2': Issue #16250: Fix URLError invocation with proper args. http://hg.python.org/cpython/rev/5e71f2712076 New changeset 30547e2cd04d by Senthil Kumaran in branch '3.3': Issue #16250: Fix URLError invocati

[issue16250] URLError invoked with reason as filename

Roundup Robot added the comment: New changeset 3fb84c1da8c5 by Senthil Kumaran in branch '2.7': Add some tests in 2.7 for Issue #16250 http://hg.python.org/cpython/rev/3fb84c1da8c5 -- ___ Python tracker ___

[issue16250] URLError invoked with reason as filename

Senthil Kumaran added the comment: This is fixed in all versions now. -- assignee: -> orsenthil resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker