[issue16274] test_asyncore failing on Solaris 10 2.7 (nitrogen/s10)

Changes by Trent Nelson : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue16274] test_asyncore failing on Solaris 10 2.7 (nitrogen/s10)

Roundup Robot added the comment: New changeset 937fa81500e2 by Trent Nelson in branch '2.7': Issue #16274: Fix test_asyncore on Solaris. http://hg.python.org/cpython/rev/937fa81500e2 -- ___ Python tracker _

[issue16274] test_asyncore failing on Solaris 10 2.7 (nitrogen/s10)

Trent Nelson added the comment: On Mon, Oct 22, 2012 at 05:51:23AM -0700, Giampaolo Rodola' wrote: > > Giampaolo Rodola' added the comment: > > This should do it: > > diff --git a/Lib/test/test_asyncore.py b/Lib/test/test_asyncore.py > --- a/Lib/test/test_asyncore.py > +++ b/Lib/test/test_asyn

[issue16274] test_asyncore failing on Solaris 10 2.7 (nitrogen/s10)

Giampaolo Rodola' added the comment: Yes, now that I think of it that is how accept() is supposed to be used in 2.7 (back then I did also update doc examples in order to enforce this use case) so this is a test suite issue. -- ___ Python tracker

[issue16274] test_asyncore failing on Solaris 10 2.7 (nitrogen/s10)

Giampaolo Rodola' added the comment: This should do it: diff --git a/Lib/test/test_asyncore.py b/Lib/test/test_asyncore.py --- a/Lib/test/test_asyncore.py +++ b/Lib/test/test_asyncore.py @@ -484,8 +484,9 @@ return self.socket.getsockname()[:2] def handle_accept(self): -so

[issue16274] test_asyncore failing on Solaris 10 2.7 (nitrogen/s10)

Jesús Cea Avión added the comment: Keeping the issue open until Trent can commit a new patch, according to msg173256. -- ___ Python tracker ___ _

[issue16274] test_asyncore failing on Solaris 10 2.7 (nitrogen/s10)

Changes by Trent Nelson : -- status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue16274] test_asyncore failing on Solaris 10 2.7 (nitrogen/s10)

Jesús Cea Avión added the comment: "hg annotate" is useful :-) Changes in 3.2 look like coming from here: """ jcea@ubuntu:~/hg/python/cpython$ hg log -r 64988 changeset: 64988:0f8c2eb89f46 user:Antoine Pitrou date:Tue Sep 28 21:23:11 2010 + summary: Issue #9090: When

[issue16274] test_asyncore failing on Solaris 10 2.7 (nitrogen/s10)

Trent Nelson added the comment: That backport wasn't appropriate -- it included new public members to asyncore that were introduced in 3.2. I'll work on a less intrusive patch. -- ___ Python tracker _

[issue16274] test_asyncore failing on Solaris 10 2.7 (nitrogen/s10)

Roundup Robot added the comment: New changeset 2f0770cc6d3f by Trent Nelson in branch '2.7': Issue #16274: revert r79813:90a46f8943d0 changes to asyncore/test_asyncore. http://hg.python.org/cpython/rev/2f0770cc6d3f -- ___ Python tracker

[issue16274] test_asyncore failing on Solaris 10 2.7 (nitrogen/s10)

Trent Nelson added the comment: Patch applied and everything passes, so closing for now. -- status: open -> closed ___ Python tracker ___

[issue16274] test_asyncore failing on Solaris 10 2.7 (nitrogen/s10)

Roundup Robot added the comment: New changeset 90a46f8943d0 by Trent Nelson in branch '2.7': Issue #16274: backport of 3.2's asyncore/test_asyncore to 2.7. http://hg.python.org/cpython/rev/90a46f8943d0 -- nosy: +python-dev ___ Python tracker

[issue16274] test_asyncore failing on Solaris 10 2.7 (nitrogen/s10)

Trent Nelson added the comment: Ok, attached patch is a semantic backport matching 2.7 to 3.2. All tests pass with this patch. (I can't comment on whether or not the changes in 3.2 actually fix an underlying issue, or just hide it better.) -- keywords: +patch Added file: http://bugs.

[issue16274] test_asyncore failing on Solaris 10 2.7 (nitrogen/s10)

Trent Nelson added the comment: Yeah I've just backported the semantic changes between asyncore and test_asyncore from 3.2 -> 2.7. I'll report back shortly with results. -- ___ Python tracker

[issue16274] test_asyncore failing on Solaris 10 2.7 (nitrogen/s10)

Giampaolo Rodola' added the comment: I notice there are some differences in sock_accept() (Modules/socketmodule.c) between 2.7 and 3.2. Maybe a bugfix which wasn't backported to 2.7. -- ___ Python tracker

[issue16274] test_asyncore failing on Solaris 10 2.7 (nitrogen/s10)

Trent Nelson added the comment: 3.2 appears fine. This behavior only seems to happen on 2.7. The affected tests are: test_quick_connect (test.test_asyncore.TestAPI_UseSelect) test_quick_connect (test.test_asyncore.TestAPI_UsePoll) Doing some more digging. -- __

[issue16274] test_asyncore failing on Solaris 10 2.7 (nitrogen/s10)

Giampaolo Rodola' added the comment: That is weird. accept() should never return None. What about python 3.x? -- nosy: +giampaolo.rodola ___ Python tracker ___ __

[issue16274] test_asyncore failing on Solaris 10 2.7 (nitrogen/s10)

New submission from Trent Nelson: % ./python -m test.regrtest test_asyncore test_asyncore Exception in thread Thread-3: Traceback (most recent call last): File "/home/cpython/hg/2.7/Lib/threading.py", line 552, in __bootstrap_inner self.run() File "/home/cpython/hg/2.7/Lib/threading.py",