[issue16284] concurrent.futures ThreadPoolExecutor keeps unnecessary references to worker functions.

2012-11-03 Thread Andrew Svetlov
Changes by Andrew Svetlov : -- stage: test needed -> committed/rejected ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue16284] concurrent.futures ThreadPoolExecutor keeps unnecessary references to worker functions.

2012-11-03 Thread Andrew Svetlov
Andrew Svetlov added the comment: Committed. Thanks. -- resolution: -> fixed stage: -> test needed status: open -> closed ___ Python tracker ___ ___

[issue16284] concurrent.futures ThreadPoolExecutor keeps unnecessary references to worker functions.

2012-11-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 70cef0a160cf by Andrew Svetlov in branch 'default': Issue #16284: Prevent keeping unnecessary references to worker functions in concurrent.futures ThreadPoolExecutor. http://hg.python.org/cpython/rev/70cef0a160cf -- nosy: +python-dev _

[issue16284] concurrent.futures ThreadPoolExecutor keeps unnecessary references to worker functions.

2012-11-03 Thread Taras Lyapun
Taras Lyapun added the comment: Added comments to patch -- nosy: +lyapun Added file: http://bugs.python.org/file27850/issue16284_with_comments.diff ___ Python tracker ___ ___

[issue16284] concurrent.futures ThreadPoolExecutor keeps unnecessary references to worker functions.

2012-11-01 Thread Andrew Svetlov
Andrew Svetlov added the comment: Updated patch to execute tests only for CPython. -- nosy: +asvetlov Added file: http://bugs.python.org/file27820/kill_reference_3.diff ___ Python tracker __

[issue16284] concurrent.futures ThreadPoolExecutor keeps unnecessary references to worker functions.

2012-10-24 Thread Richard Oudkerk
Richard Oudkerk added the comment: LGTM -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue16284] concurrent.futures ThreadPoolExecutor keeps unnecessary references to worker functions.

2012-10-21 Thread Brian Quinlan
Brian Quinlan added the comment: The concurrent.futures stuff looks good to me. Could you add a comment explaining why the delete is necessary? And, as Antoine said, the test should be CPython only. -- ___ Python tracker

[issue16284] concurrent.futures ThreadPoolExecutor keeps unnecessary references to worker functions.

2012-10-20 Thread Antoine Pitrou
Antoine Pitrou added the comment: Sounds fine to me. You might want to make the test CPython-specific. -- nosy: +pitrou ___ Python tracker ___ ___

[issue16284] concurrent.futures ThreadPoolExecutor keeps unnecessary references to worker functions.

2012-10-20 Thread Mark Dickinson
Changes by Mark Dickinson : -- nosy: +jnoller, sbt ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue16284] concurrent.futures ThreadPoolExecutor keeps unnecessary references to worker functions.

2012-10-20 Thread Mark Dickinson
Mark Dickinson added the comment: A new patch (with tests), and a fuller explanation: At work, we've got Python talking to a customer's existing COM library; we're using Thomas Heller's 'comtypes' library to do that. Unfortunately, comtypes depends quite a lot on __del__-time cleanup, so refe

[issue16284] concurrent.futures ThreadPoolExecutor keeps unnecessary references to worker functions.

2012-10-19 Thread Ralf Schmitt
Changes by Ralf Schmitt : -- nosy: +schmir ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue16284] concurrent.futures ThreadPoolExecutor keeps unnecessary references to worker functions.

2012-10-19 Thread Mark Dickinson
New submission from Mark Dickinson: The ThreadPoolExecutor unnecessarily keeps references to _WorkItem objects. With the attached patch (which lacks a test), all tests still pass, and the references are removed as soon as they're no longer needed. -- files: kill_reference.diff keyword