[issue16357] SSLSocket created from SSLContext.wrap_socket doesn't include cert/keyfile

2012-12-13 Thread Jesús Cea Avión
Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16357 ___ ___ Python-bugs-list mailing list

[issue16357] SSLSocket created from SSLContext.wrap_socket doesn't include cert/keyfile

2012-11-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset f475332df9b5 by Antoine Pitrou in branch '3.2': Issue #16357: fix calling accept() on a SSLSocket created through SSLContext.wrap_socket(). http://hg.python.org/cpython/rev/f475332df9b5 New changeset 9510a9641c80 by Antoine Pitrou in branch '3.3':

[issue16357] SSLSocket created from SSLContext.wrap_socket doesn't include cert/keyfile

2012-11-10 Thread Antoine Pitrou
Antoine Pitrou added the comment: I've reworked the patch a bit and committed it. Thank you for reporting this! -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org

[issue16357] SSLSocket created from SSLContext.wrap_socket doesn't include cert/keyfile

2012-10-29 Thread Jeff McNeil
New submission from Jeff McNeil: mcjeff@martian:~/cpython$ ./python -V Python 3.4.0a0 When an SSLSocket is created via SSLContext.wrap_socket, it is passed a _context parameter directly. SSLSocket.__init__ sets self.context at this point, but it does not set self.keyfile or self.certfile.

[issue16357] SSLSocket created from SSLContext.wrap_socket doesn't include cert/keyfile

2012-10-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: I don't understand your code snippet: you don't seem to wrap the socket anywhere (paste error?). As for the patch, it would be nice to add a corresponding test in Lib/test/test_ssl.py. -- nosy: +pitrou stage: - patch review type: - behavior

[issue16357] SSLSocket created from SSLContext.wrap_socket doesn't include cert/keyfile

2012-10-29 Thread Jeff McNeil
Jeff McNeil added the comment: Ak! Yes, cut and paste error. Python 3.4.0a0 (default:57a33af85407, Oct 27 2012, 21:26:30) [GCC 4.4.3] on linux Type help, copyright, credits or license for more information. import ssl c = ssl.SSLContext(ssl.PROTOCOL_SSLv23)

[issue16357] SSLSocket created from SSLContext.wrap_socket doesn't include cert/keyfile

2012-10-29 Thread Jeff McNeil
Jeff McNeil added the comment: Updated to pass in the parent context only actually, as it doesn't look like all of the attributes on SSLSocket will be set if a context was initially passed in. -- Added file: http://bugs.python.org/file27784/ssl_context_2.patch