[issue16445] SEGFAULT when deleting Exception.message

Antoine Pitrou added the comment: This looks like it is fixed by Mark's commit. Other proposals should go into separate issues. -- nosy: +pitrou resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed versions: -Python 3.2, Python 3.3, Python 3.4

[issue16445] SEGFAULT when deleting Exception.message

Mark Lawrence added the comment: It looks as if this issue can be closed as a fix has been committed. However a new issue will be needed if the advice offered in msg181839 is followed. -- nosy: +BreamoreBoy ___ Python tracker

[issue16445] SEGFAULT when deleting Exception.message

Roundup Robot added the comment: New changeset 0e41c4466d58 by Mark Dickinson in branch '2.7': Issue #16445: Fix potential segmentation fault when deleting an exception message. http://hg.python.org/cpython/rev/0e41c4466d58 -- nosy: +python-dev ___ P

[issue16445] SEGFAULT when deleting Exception.message

Serhiy Storchaka added the comment: > Here's a simple patch (against 2.7) for this particular issue. LGTM. -- ___ Python tracker ___

[issue16445] SEGFAULT when deleting Exception.message

Mark Dickinson added the comment: Here's a simple patch (against 2.7) for this particular issue. -- Added file: http://bugs.python.org/file29035/issue16445.patch ___ Python tracker _

[issue16445] SEGFAULT when deleting Exception.message

Mark Dickinson added the comment: Can I suggest fixing this particular issue with a dedicated patch, and opening another issue to consider the large automated replacements that Victor's proposing? -- ___ Python tracker

[issue16445] SEGFAULT when deleting Exception.message

Changes by Serhiy Storchaka : -- priority: normal -> high ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue16445] SEGFAULT when deleting Exception.message

Changes by Mark Dickinson : -- nosy: +mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue16445] SEGFAULT when deleting Exception.message

Changes by John O'Connor : -- nosy: +jcon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue16445] SEGFAULT when deleting Exception.message

Serhiy Storchaka added the comment: Victor, I will be glad to review any related patches, but please split the patch on several patches, from most undoubted to more sophisticated patterns. -- ___ Python tracker __

[issue16445] SEGFAULT when deleting Exception.message

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue16445] SEGFAULT when deleting Exception.message

Serhiy Storchaka added the comment: The Coccinelle looks as an amazing tool! I propose split a patch on several patches (autogenerated code, attributes clearing, other pointer expressions (as *exceptionObject or unicode_latin1[i]) clearing, and local pointers clearing at the end) and commit th

[issue16445] SEGFAULT when deleting Exception.message

STINNER Victor added the comment: py_clear.spatch replaces: Py_DECREF(obj->attr); obj->attr = NULL; but also: Py_DECREF(obj); obj = NULL; If the second pattern is not dangerous, py_clear.spatch can be modified to only match the first pattern: see py_decref_replace.spatch of issue #16447 for

[issue16445] SEGFAULT when deleting Exception.message

STINNER Victor added the comment: python27_pyclear.patch does fix the use case described in msg175203, but it doesn't fix #16447. -- ___ Python tracker ___ _

[issue16445] SEGFAULT when deleting Exception.message

STINNER Victor added the comment: The "spatch" doesn't match the following macro: Modules/_testcapimodule.c:#define UNBIND(X) Py_DECREF(X); (X) = NULL -- Python/Python-ast.c is autogenerated from Parser/asdl_c.py, the .py file should be fixed instead. -- __

[issue16445] SEGFAULT when deleting Exception.message

Changes by STINNER Victor : -- keywords: +patch Added file: http://bugs.python.org/file27930/python27_pyclear.patch ___ Python tracker ___ ___

[issue16445] SEGFAULT when deleting Exception.message

STINNER Victor added the comment: According to Amaury an IRC, replacing "Py_XDECREF(obj->attr); obj->attr = NULL;" pattern with "Py_CLEAR(obj->attr);" should fix the issue. Instead of opening one issue per occurence of this pattern, it is possible to write a semantic patch to do the replace on

[issue16445] SEGFAULT when deleting Exception.message

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue16445] SEGFAULT when deleting Exception.message

New submission from Amaury Forgeot d'Arc: The script below segfaults cpython2.7. The cause is in BaseException_set_message(), which calls Py_XDECREF(self->message) and thus can call back into Python code with a dangling PyObject* pointer. Py_CLEAR should be used instead. class Nasty(str):