Andrew Svetlov added the comment:
LGTM
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16495
___
___
Python-bugs-list mailing list
Unsubscribe:
Roundup Robot added the comment:
New changeset 3fb9e38b00e8 by Chris Jerdonek in branch 'default':
Issue #16495: remove extraneous NULL encoding check from bytes_decode().
http://hg.python.org/cpython/rev/3fb9e38b00e8
--
nosy: +python-dev
___
Python
Changes by Chris Jerdonek chris.jerdo...@gmail.com:
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16495
Changes by Andrew Svetlov andrew.svet...@gmail.com:
--
nosy: +asvetlov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16495
___
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16495
___
___
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16495
___
___
Python-bugs-list mailing list
Chris Jerdonek added the comment:
Patch attached. The tests pass.
--
keywords: +patch
Added file: http://bugs.python.org/file28039/issue-16495-1-default.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16495
New submission from Chris Jerdonek:
The code below in bytes_decode() is unnecessary:
if (encoding == NULL)
encoding = PyUnicode_GetDefaultEncoding();
(from
http://hg.python.org/cpython/file/e9af9b1ca67e/Objects/bytesobject.c#l2230 )
because PyUnicode_FromEncodedObject() already
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16495
___
___
Chris Jerdonek added the comment:
For the record, there is a test for the default encoding:
http://hg.python.org/cpython/file/e9af9b1ca67e/Lib/test/test_bytes.py#l209
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16495
10 matches
Mail list logo