[issue16525] wave file module does not support 32bit float format

Change by Josh Lee : -- nosy: +jleedev ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16525] wave file module does not support 32bit float format

Sebastian Kraft added the comment: After the last changes in the development version of python 3.4 the patch cannot be applied anymore. As the the other audio file readers and the wave module share a common API it may be not desireable to simply enhance the wave module with support for

[issue16525] wave file module does not support 32bit float format

Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - serhiy.storchaka nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16525 ___

[issue16525] wave file module does not support 32bit float format

Harvey Ormston added the comment: Thanks Sebastian. That makes sense. I've tried the updated patch and it works just fine for me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16525 ___

[issue16525] wave file module does not support 32bit float format

Changes by Sebastian Kraft sebastian_kr...@gmx.de: Removed file: http://bugs.python.org/file28122/wave_float_issue16525.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16525 ___

[issue16525] wave file module does not support 32bit float format

Sebastian Kraft added the comment: Thanks for the hint Harvey! I have updated my patch to include your changes, but only applied the second hunk for the following reasons: Wave_read should not assume any wave format, as it is expected to open a file during initialization. So actually the only

[issue16525] wave file module does not support 32bit float format

Harvey Ormston added the comment: I see that this issue applies to Python 3.4. Nevertheless, I am now using the submitted patch (http://bugs.python.org/file28122/wave_float_issue16525.patch) with Python 2.7. I find that the patched module fails when calling getwavformat(), becuase the

[issue16525] wave file module does not support 32bit float format

Sebastian Kraft added the comment: Any news or feedback regarding my patch? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16525 ___ ___

[issue16525] wave file module does not support 32bit float format

Changes by Antoine Pitrou pit...@free.fr: -- nosy: +mark.dickinson stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16525 ___

[issue16525] wave file module does not support 32bit float format

Sebastian Kraft added the comment: Contribution agreement is now attached to my account. So the review can start ;) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16525 ___

[issue16525] wave file module does not support 32bit float format

Sebastian Kraft added the comment: Attached to this mail you find my patch for the implementation of support for 8, 16, 24, 32 bit signed int PCM and 32, 64 bit float. 24bit on big endian systems is buggy, but this will be reported in another ticket. The modified test checks all number

[issue16525] wave file module does not support 32bit float format

Sebastian Kraft added the comment: Write support is no problem, I will add this. From reading the spec in the link you provided I think the implementation in general is OK. Everything apart WAVE_FORMAT_PCM should have an extension size cbSize, that's right. But only WAVE_FORMAT_EXTENSIBLE

[issue16525] wave file module does not support 32bit float format

Jesús Cea Avión added the comment: Sebastian, Could you possibly write a patch with a test?. Could you possibly fill a contributor agreement? Details in http://www.python.org/psf/contrib/ -- ___ Python tracker rep...@bugs.python.org

[issue16525] wave file module does not support 32bit float format

Sebastian Kraft added the comment: I will create a patch together with a testset of example files and also fill out the agreement. BTW: readframes() returns bad data for 24bit PCM if big_endian==True. Furthermore IMO it doesn't make sense to return a byte stream in little endian order on a

[issue16525] wave file module does not support 32bit float format

Jesús Cea Avión added the comment: About the 24 bit PCM bug, please fill another bug. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16525 ___

[issue16525] wave file module does not support 32bit float format

New submission from Sebastian Kraft: The wave module cannot read audio WAV files containing 32bit float values. This is a very common file type for professional audio! There has already been a patch some years ago which works fine but was finally not applied. I can confirm that it does not

[issue16525] wave file module does not support 32bit float format

Changes by Berker Peksag berker.pek...@gmail.com: -- versions: -Python 2.6, Python 3.1, Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16525 ___

[issue16525] wave file module does not support 32bit float format

Jesús Cea Avión added the comment: This is a new feature. Targeting Python 3.4. -- nosy: +jcea versions: -Python 2.7, Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16525

[issue16525] wave file module does not support 32bit float format

Jesús Cea Avión added the comment: Can somebody point to a floating point WAVE specification?. I think the issues raised in the original bug still stands. Also, support for writing should be provided too.