Roundup Robot added the comment:
New changeset 3dff836cedef by Serhiy Storchaka in branch 'default':
Closes #16551. Cleanup pickle.py.
http://hg.python.org/cpython/rev/3dff836cedef
--
nosy: +python-dev
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
Serhiy Storchaka added the comment:
Patch updated in response to Alexandre's comments. In additional to his
suggestions some other minor things simplified. _batch_appends and
_batch_setitems now use islice instead range. Some bugs found and new issues
created (issue17710, issue17711).
Serhiy Storchaka added the comment:
Here is an updated patch which get rid of trick with attribute caching. Globals
used instead. Also added some minor style changes (dropped redundant semicolons
and wrapped too long lines).
--
Added file:
Serhiy Storchaka added the comment:
In response to Alexandre's comment on Rietveld. Access to a local variable is
faster than to a global one and the current implementation uses this for
struct.pack. I just use same trick for struct.unpack. Here is a microbenchmark
which demonstrate some
Alexandre Vassalotti added the comment:
My point is I would prefer that we keep all optimizations to only the _pickle C
module and keep the Python implementation as simple as possible.
Also, I doubt the slight speedup shown by your microbenchmark will actually
result in any significant
Antoine Pitrou added the comment:
Patch looks fine to me. Do you want to go ahead?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16551
___
___
Serhiy Storchaka added the comment:
Ping.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16551
___
___
Python-bugs-list mailing list
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16551
___
___
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16551
___
___
Python-bugs-list mailing list
New submission from Serhiy Storchaka:
This issue inspired by issue12848. The proposed patch get rid of the marshal
module (the struct module used instead), removes some redundant code, and
changes the code to use more modern idioms.
--
components: Library (Lib)
files:
10 matches
Mail list logo