[issue1657] [patch] epoll and kqueue wrappers for the select module

A.M. Kuchling added the comment: What exactly needs to be finished in the documentation? There are sections for the epoll and kqueue objects, and the epoll section looks fine, if brief. Is the problem that the kqueue section says things like 'filter-specific data' with no explanation?

[issue1657] [patch] epoll and kqueue wrappers for the select module

Erik Gorset added the comment: The kqueue implementation is not working. It has a silly bug: - chl[i] = ((kqueue_event_Object *)ei)->e; + chl[i++] = ((kqueue_event_Object *)ei)->e; I've created issue 5910 and included a patch, which a

[issue1657] [patch] epoll and kqueue wrappers for the select module

Changes by intgr : -- nosy: +intgr ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailma

[issue1657] [patch] epoll and kqueue wrappers for the select module

Christian Heimes <[EMAIL PROTECTED]> added the comment: I've applied the patch in r61722. TODO: finish the documentation, any help is appreciated -- components: +Documentation -Extension Modules resolution: -> accepted __ Tracker <[EMAIL PROTECTED]>

[issue1657] [patch] epoll and kqueue wrappers for the select module

Guido van Rossum <[EMAIL PROTECTED]> added the comment: Go. __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue1657] [patch] epoll and kqueue wrappers for the select module

Christian Heimes <[EMAIL PROTECTED]> added the comment: Say "Go" and I'll check the patch in ASAP. __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list

[issue1657] [patch] epoll and kqueue wrappers for the select module

Guido van Rossum <[EMAIL PROTECTED]> added the comment: pyepoll for static names sounds fine (assuming you want some consistency). Given all the rave reviews, what are the chances that you'll be checking this in soon? __ Tracker <[EMAIL PROTECTED]>

[issue1657] [patch] epoll and kqueue wrappers for the select module

Christian Heimes <[EMAIL PROTECTED]> added the comment: I had to use some kind of prefix to avoid naming collisions with the epoll_* functions for the epoll header file. pyepoll sounded reasonable to me. __ Tracker <[EMAIL PROTECTED]>

[issue1657] [patch] epoll and kqueue wrappers for the select module

Jim Jewett <[EMAIL PROTECTED]> added the comment: Is pyepoll a good prefix? To me, it looks a lot like the _Py and Py reservered namespaces, but not quite... -- nosy: +jimjjewett __ Tracker <[EMAIL PROTECTED]>

[issue1657] [patch] epoll and kqueue wrappers for the select module

Gregory P. Smith <[EMAIL PROTECTED]> added the comment: +1 trunk_select_epoll_kqueue9.patch looks good to me. style nit: I'd just use self.fail("error message") instead of raise AssertionError("error message") within unittests. regardless, both work so I don't care. :) -- nosy: +greg

[issue1657] [patch] epoll and kqueue wrappers for the select module

Trent Nelson <[EMAIL PROTECTED]> added the comment: Patch applies cleanly on FreeBSD 6.2-STABLE and all tests pass. Can't comment on technical accuracy. -- nosy: +Trent.Nelson __ Tracker <[EMAIL PROTECTED]> ___

[issue1657] [patch] epoll and kqueue wrappers for the select module

Christian Heimes added the comment: I love to get it into the next alpha but I don't have time to today. Can you take it to the mailing list and ask somebody to review and submit the patch? __ Tracker <[EMAIL PROTECTED]>

[issue1657] [patch] epoll and kqueue wrappers for the select module

Thomas Herve added the comment: Is there a chance for this go in the first alpha? FWIW, I've tested it with twisted kqueue and epoll reactors, and didn't get any problems. There are still 2 typos in the patch: KQ_ADD is used 2 times in the docs instead of KQ_EV_ADD. Everything else looks good to

[issue1657] [patch] epoll and kqueue wrappers for the select module

Changes by Christian Heimes: Removed file: http://bugs.python.org/file9241/trunk_select_epoll_kqueue8.patch __ Tracker <[EMAIL PROTECTED]> __ ___ Python

[issue1657] [patch] epoll and kqueue wrappers for the select module

Changes by Christian Heimes: Removed file: http://bugs.python.org/file9027/trunk_select_epoll_kqueue6.patch __ Tracker <[EMAIL PROTECTED]> __ ___ Python

[issue1657] [patch] epoll and kqueue wrappers for the select module

Changes by Christian Heimes: Removed file: http://bugs.python.org/file9029/trunk_select_epoll_kqueue7.patch __ Tracker <[EMAIL PROTECTED]> __ ___ Python

[issue1657] [patch] epoll and kqueue wrappers for the select module

Changes by Christian Heimes: Removed file: http://bugs.python.org/file9019/trunk_select_epoll_kqueue5.patch __ Tracker <[EMAIL PROTECTED]> __ ___ Python

[issue1657] [patch] epoll and kqueue wrappers for the select module

Christian Heimes added the comment: I've updated the patch. The latest patch didn't contain the unit tests and it failed to apply cleanly, too. Added file: http://bugs.python.org/file9535/trunk_select_epoll_kqueue9.patch __ Tracker <[EMAIL PROTECTED]>

[issue1657] [patch] epoll and kqueue wrappers for the select module

Changes by Giampaolo Rodola': -- nosy: +giampaolo.rodola __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http

[issue1657] [patch] epoll and kqueue wrappers for the select module

Changes by Christian Heimes: Added file: http://bugs.python.org/file9241/trunk_select_epoll_kqueue8.patch __ Tracker <[EMAIL PROTECTED]> __ ___ Python-b

[issue1657] [patch] epoll and kqueue wrappers for the select module

Christian Heimes added the comment: Yeah, it's a reasonable suggestion. I'm changing the code to seconds as positive float and None = blocking. __ Tracker <[EMAIL PROTECTED]> __ ___

[issue1657] [patch] epoll and kqueue wrappers for the select module

Guido van Rossum added the comment: Still haven't had the time (sorry!), but one comment: please don't specify timeouts in millisecond. We use seconds (floats if necessary) everywhere else in Python, regardless of the underlying data structure or resolution. __ Tr

[issue1657] [patch] epoll and kqueue wrappers for the select module

Christian Heimes added the comment: Can somebody else review the patch? therve from the Twisted team has reviewed it but I like to get an opinion of another core developer. Guido seems to be too busy. __ Tracker <[EMAIL PROTECTED]>

[issue1657] [patch] epoll and kqueue wrappers for the select module

Guido van Rossum added the comment: Not yet, I ran out of time. Can you hold on for another week? __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list

[issue1657] [patch] epoll and kqueue wrappers for the select module

Christian Heimes added the comment: Guido, have you reviewed the patch and are you fine with it? -- components: +Extension Modules nosy: +gvanrossum __ Tracker <[EMAIL PROTECTED]> __ _

[issue1657] [patch] epoll and kqueue wrappers for the select module

Thomas Herve added the comment: You have to use sys.platform to get 'darwin', not os.name. The rest of the test seems good. I didn't spot the check of EEXIST in pyepoll_internal_ctl, I'm not sure it's a good idea. I understand it's for being able to only use register, but it's not the way it's m

[issue1657] [patch] epoll and kqueue wrappers for the select module

Thomas Herve added the comment: > What do you suggest as sort criteria? The natural sort of the tuple you used for equality, I'd say. __ Tracker <[EMAIL PROTECTED]> __

[issue1657] [patch] epoll and kqueue wrappers for the select module

Christian Heimes added the comment: > I attached a patch with a more complete test of kqueue. It's not that > great, but it's a thing. I've only tested on OS X, but it works. A small unit test is better than no unit test :) > Regarding the ability of building an epoll object from a fd, it mi

[issue1657] [patch] epoll and kqueue wrappers for the select module

Thomas Herve added the comment: I attached a patch with a more complete test of kqueue. It's not that great, but it's a thing. I've only tested on OS X, but it works. Regarding the ability of building an epoll object from a fd, it might be usefull in some corner cases, but that's not a priority.

[issue1657] [patch] epoll and kqueue wrappers for the select module

Changes by Thomas Herve: Added file: http://bugs.python.org/file9020/test_kqueue.diff __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing lis

[issue1657] [patch] epoll and kqueue wrappers for the select module

Changes by Christian Heimes: Removed file: http://bugs.python.org/file9018/trunk_select_epoll_kqueue4.patch __ Tracker <[EMAIL PROTECTED]> __ ___ Python

[issue1657] [patch] epoll and kqueue wrappers for the select module

Thomas Herve added the comment: Here I go for kqueue: * the docstring of test_kqueue.py is wrong * the tests are a bit light. It would be good the have a test like test_control_and_wait in test_epoll. * the kqueue_queue_control (and the pyepoll_poll) are now completely wrong! You should not li

[issue1657] [patch] epoll and kqueue wrappers for the select module

Changes by Christian Heimes: Removed file: http://bugs.python.org/file9014/trunk_select_epoll_kqueue2.patch __ Tracker <[EMAIL PROTECTED]> __ ___ Python

[issue1657] [patch] epoll and kqueue wrappers for the select module

Changes by Christian Heimes: Removed file: http://bugs.python.org/file9017/trunk_select_epoll_kqueue3.patch __ Tracker <[EMAIL PROTECTED]> __ ___ Python

[issue1657] [patch] epoll and kqueue wrappers for the select module

Changes by Christian Heimes: Removed file: http://bugs.python.org/file9010/trunk_select_epoll_kqueue.patch __ Tracker <[EMAIL PROTECTED]> __ ___ Python-

[issue1657] [patch] epoll and kqueue wrappers for the select module

Christian Heimes added the comment: > Some remarks: > * the name of the function used for PyArg_ParseTupleAndKeywords in > register, modify, unregister is set to control instead of the good name. Fixed > * there is a leak in pyepoll_new if the parsing of arguments fails. Fixed > * the inde

[issue1657] [patch] epoll and kqueue wrappers for the select module

Thomas Herve added the comment: Some remarks: * the name of the function used for PyArg_ParseTupleAndKeywords in register, modify, unregister is set to control instead of the good name. * there is a leak in pyepoll_new if the parsing of arguments fails. * the indentation is sometimes tabs, som

[issue1657] [patch] epoll and kqueue wrappers for the select module

Changes by Christian Heimes: Added file: http://bugs.python.org/file9010/trunk_select_epoll_kqueue.patch __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bu

[issue1657] [patch] epoll and kqueue wrappers for the select module

Changes by Christian Heimes: Removed file: http://bugs.python.org/file9009/trunk_select_epoll_kqueue.patch __ Tracker <[EMAIL PROTECTED]> __ ___ Python-

[issue1657] [patch] epoll and kqueue wrappers for the select module

Changes by Christian Heimes: Removed file: http://bugs.python.org/file8999/trunk_select_epoll3.patch __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-l