Changes by Christian Heimes li...@cheimes.de:
--
nosy: +christian.heimes
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16597
___
___
Serhiy Storchaka added the comment:
There are a lot of people in the nosy list already. Does anyone have enough
experience with exception machinery to review the patch (especially C part)?
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Patch updated with Benjamin's nit.
--
Added file: http://bugs.python.org/file28378/bufferedio_finally_close_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16597
Roundup Robot added the comment:
New changeset b0602a1eb3f6 by Benjamin Peterson in branch '3.3':
call close on the underlying stream even if flush raises (closes #16597)
http://hg.python.org/cpython/rev/b0602a1eb3f6
New changeset 142012e47c3b by Benjamin Peterson in branch 'default':
merge 3.3
Serhiy Storchaka added the comment:
Here is a patch for 3.2.
--
Added file:
http://bugs.python.org/file28380/bufferedio_finally_close-3.2_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16597
Serhiy Storchaka added the comment:
Here is a patch for 2.7.
--
Added file:
http://bugs.python.org/file28381/bufferedio_finally_close-2.7_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16597
Benjamin Peterson added the comment:
I think we can leave 3.2 alone.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16597
___
___
Roundup Robot added the comment:
New changeset b6ff6ac1f049 by Benjamin Peterson in branch '2.7':
call close on the underlying stream even if flush raises (#16597)
http://hg.python.org/cpython/rev/b6ff6ac1f049
--
___
Python tracker
Serhiy Storchaka added the comment:
What is the peculiarity of 3.2?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16597
___
___
Serhiy Storchaka added the comment:
About Misc/NEWS. Actually fixed close() methods of: Python implementation of
BaseIO (C implementation already do right things), C implemettation of
Buffered(Reader|Writer|Random) (Python implementation already do right things)
and both implementations of
Roundup Robot added the comment:
New changeset 54372f38932e by Benjamin Peterson in branch '3.3':
improve message (#16597)
http://hg.python.org/cpython/rev/54372f38932e
New changeset faaac6ce by Benjamin Peterson in branch 'default':
merge 3.3 (#16597)
Serhiy Storchaka added the comment:
Thank you for all commits, Benjamin.
What is the peculiarity of 3.2?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16597
___
Benjamin Peterson added the comment:
2012/12/20 Serhiy Storchaka rep...@bugs.python.org:
Serhiy Storchaka added the comment:
Thank you for all commits, Benjamin.
What is the peculiarity of 3.2?
Applying bugfixes is optional. It should move to security-fix mode soon.
--
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +hynek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16597
___
___
Python-bugs-list mailing
Changes by Andrew Svetlov andrew.svet...@gmail.com:
--
nosy: +asvetlov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16597
___
___
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16597
___
___
Python-bugs-list mailing list
Serhiy Storchaka added the comment:
f = open(/dev/full, wb, buffering=0)
f.write(bWrite to full device)
Traceback (most recent call last):
File stdin, line 1, in module
OSError: [Errno 28] No space left on device
f.close()
f.closed
True
f = open(/dev/full, wb)
f.write(bWrite to full
Serhiy Storchaka added the comment:
The bug only in C implementation.
import _pyio
f = _pyio.open(/dev/full, wb)
f.write(bWrite to full device)
20
f.close()
Traceback (most recent call last):
File stdin, line 1, in module
File /home/serhiy/py/cpython/Lib/_pyio.py, line 732, in close
Serhiy Storchaka added the comment:
Here is a patch which calls close() on underlying stream even if flush() raises
an exception.
I am not sure that I correctly set a context exception. There is no other
examples in the code.
--
keywords: +patch
nosy: +benjamin.peterson, pitrou,
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file28196/bufferedio_finally_close.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16597
___
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file28197/bufferedio_finally_close.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16597
___
Changes by John-John Tedro johnjohn.te...@gmail.com:
--
title: close not being called with context manager on IOError when device is
full. - file descriptor not being closed with context manager on IOError when
device is full
___
Python tracker
John-John Tedro added the comment:
Originally discovered on
http://stackoverflow.com/questions/13649330/what-happens-to-file-descriptors-in-python-3-when-close-fails
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16597
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16597
___
24 matches
Mail list logo
