Roundup Robot added the comment:
New changeset 62f67a52b0c2 by Hynek Schlawack in branch '3.2':
#16618: Make glob.glob match consistently across strings and bytes
http://hg.python.org/cpython/rev/62f67a52b0c2
New changeset fa8c4f96d990 by Hynek Schlawack in branch '3.3':
#16618: Make glob.glob
Hynek Schlawack added the comment:
Thanks Serhiy!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16618
Hynek Schlawack added the comment:
Serhiy, are you going to update your patches? I can implement the feedback of
our Q4 Community Service Award awardee too in case you’re busy.
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Aha! It's OS/2 where glob('*/') returns result without trailing slash. Here
also glob() can return str (on 2.7) result for unicode pattern.
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Here is an updated patches. I hope it satisfies Antoine's comments.
--
Added file: http://bugs.python.org/file28398/glob_dotfiles_3.patch
Added file: http://bugs.python.org/file28399/glob_tests-2.7_3.patch
___
Changes by Hynek Schlawack h...@ox.cx:
--
nosy: +hynek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16618
___
___
Python-bugs-list mailing list
Antoine Pitrou added the comment:
See also issue16696.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16618
___
___
Python-bugs-list mailing
Antoine Pitrou added the comment:
The patch doesn't apply cleanly.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16618
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
Patches updated to resolve conflicts with recent commits. Some minor test
errors fixed.
--
Added file: http://bugs.python.org/file28333/glob_dotfiles_2.patch
Added file: http://bugs.python.org/file28334/glob_tests-2.7_2.patch
Serhiy Storchaka added the comment:
Patches updated. Unrelated changes removed.
--
Added file: http://bugs.python.org/file28335/glob_dotfiles_2.patch
Added file: http://bugs.python.org/file28336/glob_tests-2.7_2.patch
___
Python tracker
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file28333/glob_dotfiles_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16618
___
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file28334/glob_tests-2.7_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16618
___
Serhiy Storchaka added the comment:
Yet one attempt.
--
Added file: http://bugs.python.org/file28338/glob_dotfiles_2.patch
Added file: http://bugs.python.org/file28339/glob_tests-2.7_2.patch
___
Python tracker rep...@bugs.python.org
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file28335/glob_dotfiles_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16618
___
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file28336/glob_tests-2.7_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16618
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16618
___
___
Python-bugs-list
New submission from Serhiy Storchaka:
glob ignores names which starts with dot if pattern is not starts with dot. But
this is wrong for bytes pattern in Python 3.
import glob
glob.glob('*hg')
[]
glob.glob(b'*hg')
[b'.hg']
The proposed patch fixes this inconsistency. Also it contains new
Serhiy Storchaka added the comment:
Python 2.7 is not needed the fix, however additional tests can be useful. Here
is a patch.
--
components: +Tests
versions: +Python 2.7
Added file: http://bugs.python.org/file28212/glob_tests-2.7.patch
___
Python
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16618
___
___
Python-bugs-list mailing list
19 matches
Mail list logo
