[issue16620] Avoid using private function glob.glob1() in msi module and tools

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Roundup Robot added the comment: New changeset 652a50208e89 by Serhiy Storchaka in branch '3.5': Issue #16620: Fixed AttributeError in msilib.Directory.glob(). https://hg.python.org/cpython/rev/652a50208e89 New changeset 158ae15f5809 by Serhiy Storchaka in branch '2.7': Issue #16620: Fixed Attri

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Serhiy Storchaka added the comment: It looks to me that the glob() method of msilib.Directory is broken from the born. It uses the function from the glob module, but the glob module is not imported in this source file. Even if add missed import, returned value is incorrect in Python 3. In Pyth

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Serhiy Storchaka added the comment: The patch for issue25596 removes glob1(), so we should get rid of its usage. -- priority: low -> normal ___ Python tracker ___ ___

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Serhiy Storchaka added the comment: For now there is only one place left that uses glob1(). Here is a patch that inlines glob1() in that place. -- components: -Demos and Tools, Windows stage: needs patch -> patch review versions: +Python 3.6 -Python 3.5 Added file: http://bugs.python.o

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Changes by Serhiy Storchaka : -- assignee: loewis -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Changes by Mark Lawrence : -- nosy: +steve.dower ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Raymond Hettinger added the comment: Martin, this patch touches some of your code. Do you care to take a look at it? -- assignee: -> loewis nosy: +loewis, rhettinger ___ Python tracker ___

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Mark Lawrence added the comment: Just a reminder that there are comments on Rietveld. -- nosy: +BreamoreBoy versions: +Python 3.5 -Python 3.4 ___ Python tracker ___ _

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Serhiy Storchaka added the comment: I have added some comments on Rietveld. Note that glob.glob() and glob.glob1() returns different filenames. The first returns full paths and the second returns bare filenames without a directory path. Workarounding this may require more in-depth changes to t

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Changes by Berker Peksag : -- keywords: +patch nosy: +berker.peksag Added file: http://bugs.python.org/file29263/issue16620.diff ___ Python tracker ___ __

[issue16620] Avoid using private function glob.glob1() in msi module and tools

Changes by Serhiy Storchaka : -- dependencies: +Add a function to escape metacharacters in glob/fnmatch ___ Python tracker ___ ___ Pyt

[issue16620] Avoid using private function glob.glob1() in msi module and tools

New submission from Serhiy Storchaka: Private function glob.glob1() used in Lib/msilib and Tools/msi to prevent unexpected globbing in parent directory name. ``glob.glob1(dirname, pattern)`` should be replaced by ``glob.glob(os.path.join(fnmatch.escape(dirname), pattern)`` in external code. -