[issue16644] Wrong code in ContextManagerTests.test_invalid_args() in test_subprocess.py

2012-12-26 Thread Andrew Svetlov
Andrew Svetlov added the comment: Fixed. Thanks, Serhiy. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue16644] Wrong code in ContextManagerTests.test_invalid_args() in test_subprocess.py

2012-12-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset 39be1514c16c by Andrew Svetlov in branch '3.2': fix test for subprocess (#16644) http://hg.python.org/cpython/rev/39be1514c16c New changeset 5d172190c37c by Andrew Svetlov in branch '3.3': fix test for subprocess (#16644) http://hg.python.org/cpytho

[issue16644] Wrong code in ContextManagerTests.test_invalid_args() in test_subprocess.py

2012-12-25 Thread Andrew Svetlov
Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue16644] Wrong code in ContextManagerTests.test_invalid_args() in test_subprocess.py

2012-12-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: For 3.3+ the patch can be modernized. -- Added file: http://bugs.python.org/file28344/test_subprocess_test_invalid_args_3.3.patch ___ Python tracker

[issue16644] Wrong code in ContextManagerTests.test_invalid_args() in test_subprocess.py

2012-12-08 Thread Antoine Pitrou
Antoine Pitrou added the comment: The test comes from e02021fbfe22 ("Fix #10554. Added context manager support to Popen objects."). -- nosy: +brian.curtin ___ Python tracker ___

[issue16644] Wrong code in ContextManagerTests.test_invalid_args() in test_subprocess.py

2012-12-08 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Test ContextManagerTests.test_invalid_args() in file Lib/test/test_subprocess.py contains code which has no sense. When Popen() fail then this code will not reachable. When Popen() success then c.exception will not assigned. Here is a patch with right tes