[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

Georg Brandl added the comment: I think you will, Matthew being MRAB on the mailing lists :) -- nosy: +georg.brandl ___ Python tracker ___ ___

[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

Serhiy Storchaka added the comment: Fixed. Thank you for a patch, Matthew. I hope to see more your patches. -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker

[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

Roundup Robot added the comment: New changeset 44a4f9289faa by Serhiy Storchaka in branch '3.3': Issue #16688: Fix backreferences did make case-insensitive regex fail on non-ASCII strings. http://hg.python.org/cpython/rev/44a4f9289faa New changeset c59ee1ff6f27 by Serhiy Storchaka in branch 'de

[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

Serhiy Storchaka added the comment: LGTM. Matthew, can you please submit a contributor form? http://python.org/psf/contrib/contrib-form/ http://python.org/psf/contrib/ -- stage: patch review -> commit review ___ Python tracker

[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

Changes by Matthew Barnett : Removed file: http://bugs.python.org/file28330/issue16688#3.patch ___ Python tracker ___ ___ Python-bugs-list mai

[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

Matthew Barnett added the comment: Oops! :-( Now corrected. -- Added file: http://bugs.python.org/file28332/issue16688#3.patch ___ Python tracker ___

[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

Serhiy Storchaka added the comment: The second test pass on unpatched Python. -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

Matthew Barnett added the comment: Here are some tests for the issue. -- Added file: http://bugs.python.org/file28330/issue16688#3.patch ___ Python tracker ___ __

[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

Serhiy Storchaka added the comment: The patches LGTM. How about adding a test? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

Matthew Barnett added the comment: I haven't found any other issues, so here's the second patch. -- Added file: http://bugs.python.org/file28325/issue16688#2.patch ___ Python tracker ___

[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

Matthew Barnett added the comment: I found another bug while looking through the source. On line 495 in function SRE_COUNT: if (maxcount < end - ptr && maxcount != 65535) end = ptr + maxcount*state->charsize; where 'end' and 'ptr' are of type 'char*'. That means that 'end - ptr' is

[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

Matthew Barnett added the comment: I found another bug while looking through the source. On line 495 in function SRE_COUNT: if (maxcount < end - ptr && maxcount != 65535) end = ptr + maxcount*state->charsize; where 'end' and 'ptr' are of type 'char*'. That means that 'end - ptr' is

[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

STINNER Victor added the comment: Can someone check if there is no other similar regression (introduced by the PEP 393)? 2012/12/15 Serhiy Storchaka : > > Changes by Serhiy Storchaka : > > > -- > stage: needs patch -> patch review > > ___ > Python trac

[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

Changes by Serhiy Storchaka : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

Matthew Barnett added the comment: OK, here's a patch. -- keywords: +patch Added file: http://bugs.python.org/file28321/issue16688.patch ___ Python tracker ___ __

[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

Serhiy Storchaka added the comment: Good analysis, Matthew. Are you want to submit a patch? -- keywords: +easy stage: -> needs patch ___ Python tracker ___ _

[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

Matthew Barnett added the comment: In function SRE_MATCH, the code for SRE_OP_GROUPREF (line 1290) contains this: while (p < e) { if (ctx->ptr >= end || SRE_CHARGET(state, ctx->ptr, 0) != SRE_CHARGET(state, p, 0)) RETURN_FAILURE; p += state->charsize;

[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

Ezio Melotti added the comment: It works on 2.7 too, and fails on 3.3/3.x. Maybe it's related to PEP 393? -- versions: +Python 3.4 ___ Python tracker ___

[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

Changes by STINNER Victor : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue16688] Backreferences make case-insensitive regex fail on non-ASCII strings.

New submission from pyos: The title says it all: if a regular expression that makes use of backreferences is compiled with `re.I` flag, it will always fail when matched against a string that contains characters outside of U+-U+00FF range. I've been unable to further narrow the bug down. A