Georg Brandl ge...@python.org added the comment:
Added a pony test and committed in r70883.
--
assignee: tim_one - georg.brandl
resolution: - accepted
status: open - closed
___
Python tracker rep...@bugs.python.org
Tim Lesher tles...@gmail.com added the comment:
Thanks, Antoine. I will re-check the patch against trunk and add tests
this week.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1674032
Guido van Rossum gu...@python.org added the comment:
Looking at this, I think this change is fine. The _Event class itself
holds the condition that it's checking for, and the is_set() method
doesn't acquire the lock, so there's no reason to prefer
e.wait()
if e.is_set():
GOT_IT()
over
if
Antoine Pitrou pit...@free.fr added the comment:
A test should be added to the patch, and then I think it could go in.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1674032
___
Changes by A.M. Kuchling [EMAIL PROTECTED]:
--
components: -Documentation
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1674032
___
___
Antoine Pitrou [EMAIL PROTECTED] added the comment:
I agree this would be a worthwhile addition too. Unfortunately given the
current schedule this will probably have to wait for 2.7/3.1.
--
nosy: +pitrou
versions: +Python 2.7, Python 3.1 -Python 2.6
Adam Milner [EMAIL PROTECTED] added the comment:
I would like to add my support for this change. As David described, it
is often useful to know why the x.wait() has returned, not just that it has.
--
nosy: +carmiac
___
Python tracker [EMAIL
Changes by Tim Lesher [EMAIL PROTECTED]:
--
assignee: - georg.brandl
components: +Documentation, Library (Lib) -Interpreter Core
nosy: +georg.brandl
_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1674032
Georg Brandl [EMAIL PROTECTED] added the comment:
Tim, you said this was a bad idea for conditions in #1175933 - is the
same true for Events?
--
assignee: georg.brandl - tim_one
nosy: +tim_one
_
Tracker [EMAIL PROTECTED]
