Georg Brandl added the comment:
And please don't commit cosmetic/cleanup changes to bugfix branches in the
future.
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16793
Serhiy Storchaka added the comment:
Sorry. I were understand that patches were approved by several core devs. This
issue was created for fixing regression from issue16045, but then I saw yet
some forgotten deprecated asserts. If you want, I will revert this additional
changes in 2.7 and 3.3.
Georg Brandl added the comment:
Like Raymond said in the other issue: it's not going to be a problem once
committed, but please be mindful of what you commit to bugfix branches in the
future.
--
___
Python tracker rep...@bugs.python.org
Ezio Melotti added the comment:
And please don't commit cosmetic/cleanup changes to bugfix branches in the
future.
Note that those methods are deprecated and thus raise deprecation warnings when
the tests are run. It's not just a simple cosmetic/cleanup change IMHO.
--
Georg Brandl added the comment:
That makes it more of a fix, true.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16793
___
___
Python-bugs-list
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file28458/tests_deprecated_asserts-3.3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16793
___
New submission from Serhiy Storchaka:
Here is a patches that replaces deprecated unittest assert aliases (such as
assertEquals) to its nondeprecated counterpart (if such usage is not intended).
This eliminates deprecation warnings.
--
assignee: serhiy.storchaka
components: Tests
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file28459/tests_deprecated_asserts-3.4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16793
___
Changes by Chris Jerdonek chris.jerdo...@gmail.com:
--
nosy: +chris.jerdonek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16793
___
___
Chris Jerdonek added the comment:
LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16793
___
___
Python-bugs-list mailing list
Unsubscribe:
Ezio Melotti added the comment:
LGTM.
--
nosy: +ezio.melotti
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16793
___
Roundup Robot added the comment:
New changeset a617a50d2766 by Serhiy Storchaka in branch '2.7':
Issue #16793. Replace deprecated unittest asserts with modern counterparts.
http://hg.python.org/cpython/rev/a617a50d2766
New changeset 6601818622ea by Serhiy Storchaka in branch '3.3':
Issue
Serhiy Storchaka added the comment:
I haven't committed changes to lib2to3 tests as I don't sure what version they
should be compatible.
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker
13 matches
Mail list logo