[issue1686] string.Template.safe_substitute fail when overriding pattern attribute

Roundup Robot added the comment: New changeset 8a98ee6baa1e by Florent Xicluna in branch '2.7': Issue #1686: Fix string.Template when overriding the pattern attribute. https://hg.python.org/cpython/rev/8a98ee6baa1e -- nosy: +python-dev ___ Python trac

[issue1686] string.Template.safe_substitute fail when overriding pattern attribute

Florent Xicluna added the comment: Committed with r84888. -- assignee: -> flox resolution: accepted -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue1686] string.Template.safe_substitute fail when overriding pattern attribute

Raymond Hettinger added the comment: This looks fine. -- assignee: barry -> resolution: -> accepted ___ Python tracker ___ ___ Pytho

[issue1686] string.Template.safe_substitute fail when overriding pattern attribute

Changes by Raymond Hettinger : -- Removed message: http://bugs.python.org/msg63791 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue1686] string.Template.safe_substitute fail when overriding pattern attribute

Mark Lawrence added the comment: Well what is the decision? FWIW I sway towards the +0 from msg112156 rather than the -0 from msg63791, but then what do I know? -- nosy: +BreamoreBoy ___ Python tracker __

[issue1686] string.Template.safe_substitute fail when overriding pattern attribute

Florent Xicluna added the comment: The patch (braced_override.diff) still applies on 3.2. I am +0, because it is small and tested. What is the decision? -- nosy: +flox stage: -> patch review versions: +Python 3.2 -Python 3.0 ___ Python tracker

[issue1686] string.Template.safe_substitute fail when overriding pattern attribute

Raymond Hettinger <[EMAIL PROTECTED]> added the comment: Barry, I'm -0 on this one. ISTM the cure is worst than the disease and makes the code less modifiable, understandable, or maintainable. -- nosy: +rhettinger __ Tracker <[EMAIL PROTECTED]>

[issue1686] string.Template.safe_substitute fail when overriding pattern attribute

Changes by Ilan Schnell <[EMAIL PROTECTED]>: -- assignee: -> barry nosy: +barry priority: -> normal type: -> behavior __ Tracker <[EMAIL PROTECTED]> __ _

[issue1686] string.Template.safe_substitute fail when overriding pattern attribute

David Stanek <[EMAIL PROTECTED]> added the comment: I am uploading a new diff that includes the original fix from Hagai along with some tests. -- keywords: +patch nosy: +dstanek Added file: http://bugs.python.org/file9704/braced_override.diff __ Tracker <

[issue1686] string.Template.safe_substitute fail when overriding pattern attribute

New submission from Hagai Gold: When overriding the pattern attribute on string.Template, with your own delimiters, exmp: change the ${..} to $@@..@@, safe_substitute method fail to restore the new delimiters, in case of keyerror. Problem is that the method return a specific value ==> """ retur

[issue1686] string.Template.safe_substitute fail when overriding pattern attribute

Changes by Hagai Gold: -- components: Library (Lib) files: string.py.diff nosy: hagaigold severity: normal status: open title: string.Template.safe_substitute fail when overriding pattern attribute versions: Python 3.0 Added file: http://bugs.python.org/file9024/string.py.diff