[issue16903] subprocess.Popen.communicate with universal_newlines=True doesn't accept strings on 3.2

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue16903] subprocess.Popen.communicate with universal_newlines=True doesn't accept strings on 3.2

Roundup Robot added the comment: New changeset 4206f91c974c by Serhiy Storchaka in branch '3.2': Issue #16903: Popen.communicate() on Unix now accepts strings when http://hg.python.org/cpython/rev/4206f91c974c -- nosy: +python-dev ___ Python tracker

[issue16903] subprocess.Popen.communicate with universal_newlines=True doesn't accept strings on 3.2

Serhiy Storchaka added the comment: Indeed, Popen.communicate() is incompatible not only between 3.2 and 3.3, but between Windows and POSIX too. Documentation says the input argument should be a bytes string and 3.2 on POSIX  works only with bytes strings. 3.2 on Windows and 3.3 on both platfor

[issue16903] subprocess.Popen.communicate with universal_newlines=True doesn't accept strings on 3.2

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue16903] subprocess.Popen.communicate with universal_newlines=True doesn't accept strings on 3.2

Jeremy Kloth added the comment: I would suggest that this be bumped to release blocker as currently passing bytes to communicate with universal_newlines=True on Windows causes the process to hang (see issue17077). The backported test case passes on Windows without any changes to subprocess.py

[issue16903] subprocess.Popen.communicate with universal_newlines=True doesn't accept strings on 3.2

Serhiy Storchaka added the comment: Here is a patch which adds support of strings in communicate(). It also contains a backported test from changeset 4af2c0687970 which tests this behavior. -- assignee: -> serhiy.storchaka keywords: +patch nosy: +asvetlov stage: needs patch -> patch r

[issue16903] subprocess.Popen.communicate with universal_newlines=True doesn't accept strings on 3.2

Changes by Serhiy Storchaka : -- stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue16903] subprocess.Popen.communicate with universal_newlines=True doesn't accept strings on 3.2

Changes by Chris Jerdonek : -- nosy: +chris.jerdonek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue16903] subprocess.Popen.communicate with universal_newlines=True doesn't accept strings on 3.2

Serhiy Storchaka added the comment: As quick fix I propose add support of strings (in additional to bytes) in 3.2. Perhaps we must also add support of bytes with warning in 3.3. -- ___ Python tracker _

[issue16903] subprocess.Popen.communicate with universal_newlines=True doesn't accept strings on 3.2

New submission from Serhiy Storchaka: On 3.2 subprocess.Popen.communicate with universal_newlines=True accepts bytes and doesn't accept strings. $ ./python -c "import subprocess; subprocess.Popen(['cat'], stdin=subprocess.PIPE, stdout=subprocess.PIPE, universal_newlines=True).communicate('qw