subject:"\[issue1690608\] email.utils.formataddr\(\) should be rfc2047 aware"

[issue1690608] email.utils.formataddr() should be rfc2047 aware

2011-04-07 Thread Torsten Becker

Torsten Becker added the comment: Hi David, thank you for polishing up the patch and committing it. :) I am glad I could help and I was actually about to ask you if you knew any follow-up issues. I'll definitely continue contributing as time allows. I did not submit the agreement yet, but I'll

[issue1690608] email.utils.formataddr() should be rfc2047 aware

2011-04-06 Thread R. David Murray

R. David Murray added the comment: Finally got around to committing this; thanks, Torsten. As a reward, I'm going to make you nosy on a new, related issue I'm about to create. It is, of course, your option whether you want to work on it :) By the way, have you submitted a contributor agreem

[issue1690608] email.utils.formataddr() should be rfc2047 aware

2011-04-06 Thread Roundup Robot

Roundup Robot added the comment: New changeset 184ddd9acd5a by R David Murray in branch 'default': #1690608: make formataddr RFC2047 aware. http://hg.python.org/cpython/rev/184ddd9acd5a -- nosy: +python-dev ___ Python tracker

[issue1690608] email.utils.formataddr() should be rfc2047 aware

2011-03-28 Thread R. David Murray

Changes by R. David Murray : -- versions: -Python 2.7, Python 3.1, Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue1690608] email.utils.formataddr() should be rfc2047 aware

2011-03-28 Thread R. David Murray

R. David Murray added the comment: Ah, yes. Header is probably wrong there, I should fix that at some point. Sorry for the misytpes in my last message (it was late at night for me when I wrote it :) As for time, it probably didn't take any more time than it would have to write it myself, an

[issue1690608] email.utils.formataddr() should be rfc2047 aware

2011-03-28 Thread Torsten Becker

Torsten Becker added the comment: I incorporated that change as well. My rationale behind the previous version was to be consistent with how Lib/email/header.py handled this, unfortunately I did not look around in the other classes and didn't think about that kind of compatibility. When for

[issue1690608] email.utils.formataddr() should be rfc2047 aware

2011-03-27 Thread R. David Murray

R. David Murray added the comment: Thanks. Looks good except that it should check isinstance(string) rather than isinstance(Charset), that way someone can pass a custom class that implements the Charset API if they want. (Alternatively, the check could be for an encode_header method...actua

[issue1690608] email.utils.formataddr() should be rfc2047 aware

2011-03-27 Thread Torsten Becker

Torsten Becker added the comment: I incorporated the changes as you suggested and added the text to the docs. Just out of curiosity, why are the docs repeated in email.util.rst when they are already in the docstrings? -- Added file: http://bugs.python.org/file21434/issue-1690608-v3.p

[issue1690608] email.utils.formataddr() should be rfc2047 aware

2011-03-27 Thread R. David Murray

R. David Murray added the comment: You should check if 'charset' is a string, and call Charset on it only if it is (a Charset may be passed directly in other email package interfaces, and so should be supported here as well. The test doesn't need to cater for the fact that either b or B (or q

[issue1690608] email.utils.formataddr() should be rfc2047 aware

2011-03-27 Thread Torsten Becker

Torsten Becker added the comment: > However, there should be a test for that, and I'm curious to know what > happens if you use such an address in an address field in the unmodified > email package. I added a test to check if the exceptions get thrown when a address is invalid. I also added

[issue1690608] email.utils.formataddr() should be rfc2047 aware

2011-03-27 Thread R. David Murray

R. David Murray added the comment: The general approach of the patch looks good to me. Since formataddr is designed to be called from user code that is constructing a message, having it raise for non-ascii in the address is probably OK. However, there should be a test for that, and I'm curi

[issue1690608] email.utils.formataddr() should be rfc2047 aware

2011-03-27 Thread Torsten Becker

Torsten Becker added the comment: I implemented a basic test for the issue and an attempt for a fix. I am not entirely sure with my implementation, specifically I would like to get comments concerning the following points: - Is is OK that formataddr() will now check if address is ascii safe

[issue1690608] email.utils.formataddr() should be rfc2047 aware

2011-03-13 Thread R. David Murray

Changes by R. David Murray : -- versions: +Python 2.7, Python 3.1, Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue1690608] email.utils.formataddr() should be rfc2047 aware

2010-08-05 Thread Terry J. Reedy

Terry J. Reedy added the comment: I am just responding so this will not show up on the 'unanswered issues' list. -- nosy: +terry.reedy ___ Python tracker ___ _