Guido van Rossum added the comment:
I'm not a big distutils expert myself, I can't quite interpret your
feedback. In dry-run mode, it shouldn't try to copy the script, correct?
--
keywords: +patch
__
Tracker [EMAIL PROTECTED]
toxik added the comment:
It shouldn't try to copy the script anywhere, it should just tell me
what it was going to do, by means of console.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1696
__
Guido van Rossum added the comment:
So that's correct behavior right? (I looked at the code for copy_file()
in cmd.py and it passes the dry_run parameter to the file utility
function that does the actual copying.
__
Tracker [EMAIL PROTECTED]
toxik added the comment:
Mmh, well, as far as I could tell when I tested your patch, it didn't
say it's going to copy the file, but it didn't say it isn't going to either.
As far as this ticket is concerned however, I'd say the behavior is now
fixed.
__
Tracker
Guido van Rossum added the comment:
Committed revision 59668. (2.5 branch)
Committed revision 59669. (2.6 trunk)
--
resolution: - fixed
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1696
Guido van Rossum added the comment:
Actually, only the f.close() call should be conditionalized.
Does this patch fix the issue for you?
--
assignee: - gvanrossum
nosy: +gvanrossum
priority: - normal
Added file: http://bugs.python.org/file9040/distutils.diff
toxik added the comment:
It doesn't die now, but AFAICT, it doesn't even try to copy the script
now. (With your patch.)
I might also add that this is for package_data.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1696
New submission from toxik:
It's actually py251.
113 else:
114 f.close()
115 self.copy_file(script, outfile)
Earlier, f is set to None if file is not found, and we are in dry-run
mode. Simple solution:
113 elif f:
114
