[issue16995] Add Base32 support for RFC4648 "Extended Hex" alphabet (patch attached)

Paul Ganssle added the comment: Thanks Filipe! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10 -Python 3.8 ___ Python tracker

[issue16995] Add Base32 support for RFC4648 "Extended Hex" alphabet (patch attached)

Filipe Laíns added the comment: Paul, the PR is now merged :). Can you close the bug? -- nosy: +p-ganssle ___ Python tracker ___

[issue16995] Add Base32 support for RFC4648 "Extended Hex" alphabet (patch attached)

miss-islington added the comment: New changeset 4ce6faa6c9591de6079347eccc9e61ae4e8d9e31 by Filipe Laíns in branch 'master': bpo-16995: add support for base32 extended hex (base32hex) (GH-20441) https://github.com/python/cpython/commit/4ce6faa6c9591de6079347eccc9e61ae4e8d9e31 --

[issue16995] Add Base32 support for RFC4648 "Extended Hex" alphabet (patch attached)

Change by Filipe Laíns : -- nosy: +FFY00 nosy_count: 6.0 -> 7.0 pull_requests: +19697 pull_request: https://github.com/python/cpython/pull/20441 ___ Python tracker ___

[issue16995] Add Base32 support for RFC4648 "Extended Hex" alphabet (patch attached)

Cheryl Sabella added the comment: Is there interest in having this patch converted to a pull request? -- nosy: +cheryl.sabella versions: +Python 3.8 -Python 3.6 ___ Python tracker

[issue16995] Add Base32 support for RFC4648 Extended Hex alphabet (patch attached)

Changes by Serhiy Storchaka storch...@gmail.com: Added file: http://bugs.python.org/file39996/py36_base32hex.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16995 ___

[issue16995] Add Base32 support for RFC4648 Extended Hex alphabet (patch attached)

Matthäus Wander added the comment: *facepalm* Yes, I uploaded the old patch twice. Sorry for that. - Added doc update. - Added test case that includes all 32 characters codes. I'm reusing the existing Base32 table generation logic without changes. It has been changed (in 3.4 or so) since the

[issue16995] Add Base32 support for RFC4648 Extended Hex alphabet (patch attached)

Serhiy Storchaka added the comment: Added comments on Rietveld. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16995 ___ ___ Python-bugs-list

[issue16995] Add Base32 support for RFC4648 Extended Hex alphabet (patch attached)

Changes by Serhiy Storchaka storch...@gmail.com: -- stage: needs patch - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16995 ___ ___

[issue16995] Add Base32 support for RFC4648 Extended Hex alphabet (patch attached)

Changes by Serhiy Storchaka storch...@gmail.com: -- stage: patch review - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16995 ___ ___

[issue16995] Add Base32 support for RFC4648 Extended Hex alphabet (patch attached)

Matthäus Wander added the comment: I've created a new patch that works against the current 3.5 sources. Should be fine for 3.6, I guess. Separate functions b32hexencode and b32hexdecode are used now. There is no optional parameter base32hex anymore. -- versions: +Python 3.6 -Python

[issue16995] Add Base32 support for RFC4648 Extended Hex alphabet (patch attached)

Martin Panter added the comment: Matthäus, I think you uploaded the old patch again by accident. Also, see Berker’s old comments about documentation, and my new suggestions, on the Rietveld code review, if you haven’t already. -- nosy: +vadmium ___

[issue16995] Add Base32 support for RFC4648 Extended Hex alphabet (patch attached)

Serhiy Storchaka added the comment: The patch can't be longer applied cleanly. It should be synchronized with sources. It is the last chance for this feature to get to 3.5 if somebody will update the patch and add the documentation. The feature itself LGTM. The only my doubt is about the name

[issue16995] Add Base32 support for RFC4648 Extended Hex alphabet (patch attached)

Changes by Serhiy Storchaka storch...@gmail.com: -- stage: - patch review versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16995 ___

[issue16995] Add Base32 support for RFC4648 Extended Hex alphabet (patch attached)

Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16995 ___ ___

[issue16995] Add Base32 support for RFC4648 Extended Hex alphabet (patch attached)

New submission from Matthäus Wander: RFC4648 specifies two different alphabets for Base32: 1) the common one already used in RFC3548 and implemented in Python, and 2) an Extended Hex alphabet which is used by e.g. DNSSEC NSEC3 but not yet implemented in Python. The attached patches add the

[issue16995] Add Base32 support for RFC4648 Extended Hex alphabet (patch attached)

Ezio Melotti added the comment: Since this is a new feature it can go on 3.4 only. It would also be better to include both the changes for base64.py and test_base64.py in a single patch and attach that, rather than uploading an archive that contains both. FTR the links to the relevant RFCs

[issue16995] Add Base32 support for RFC4648 Extended Hex alphabet (patch attached)

Matthäus Wander added the comment: Added single patch as requested. -- keywords: +patch Added file: http://bugs.python.org/file28772/py3_base32hex.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16995