[issue17055] ftplib.ftpcp test

2019-02-24 Thread Mark Lawrence
Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17055] ftplib.ftpcp test

2015-12-15 Thread Berker Peksag
Berker Peksag added the comment: ftpcp is undocumented and not part of the public API. It was added(changeset https://hg.python.org/cpython/rev/63cdfbb4a2bb#l1.433) in 1996 and it looks like its code was only touched for whitespace and PEP 8 fixes. I think we need to decide whether we want

[issue17055] ftplib.ftpcp test

2014-07-04 Thread Mark Lawrence
Mark Lawrence added the comment: LGTM so can we have a commit review please. -- nosy: +BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17055 ___

[issue17055] ftplib.ftpcp test

2013-01-29 Thread Łukasz Langa
Łukasz Langa added the comment: Thanks for your patch. A couple of remarks: - try to adhere to PEP 8 in your patches (most notably here: 80 characters per line, please). The rest of test_ftplib.py is also somewhat guilty in that regard but that shouldn't discourage you to do the right thing.

[issue17055] ftplib.ftpcp test

2013-01-29 Thread Michał Jastrzębski
Michał Jastrzębski added the comment: Hello, Thanks for tips. How about now? -- Added file: http://bugs.python.org/file28901/ftpcp_test.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17055

[issue17055] ftplib.ftpcp test

2013-01-29 Thread Michał Jastrzębski
Michał Jastrzębski added the comment: My mistake, this one is better. -- Added file: http://bugs.python.org/file28902/ftpcp_test.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17055 ___

[issue17055] ftplib.ftpcp test

2013-01-27 Thread Michał Jastrzębski
New submission from Michał Jastrzębski: Test for ftplib.ftpcp. -- components: Tests files: ftpcp_test.patch keywords: patch messages: 180802 nosy: inc0 priority: normal severity: normal status: open title: ftplib.ftpcp test type: enhancement versions: Python 3.4 Added file:

[issue17055] ftplib.ftpcp test

2013-01-27 Thread Ezio Melotti
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti, giampaolo.rodola stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17055 ___

[issue17055] ftplib.ftpcp test

2013-01-27 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: ftplib.ftpcp? What is that? I do not understand what you're trying to test. ftplib test suite is already pretty extended. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17055

[issue17055] ftplib.ftpcp test

2013-01-27 Thread Michał Jastrzębski
Michał Jastrzębski added the comment: Hello, Well, I ran coverage.py over this module and it turns out that this method, ftpcp has neighter tests nor docs. Most of ftplib is tested, but this one function was not. -- ___ Python tracker