[issue17099] Raise ValueError when __loader__ not defined for importlib.find_loader()

Brett Cannon added the comment: I decided not to backport since it shifts what exception is raised. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___

[issue17099] Raise ValueError when __loader__ not defined for importlib.find_loader()

Roundup Robot added the comment: New changeset cee04627bdd0 by Brett Cannon in branch 'default': Issue #17099: Have importlib.find_loader() raise ValueError when http://hg.python.org/cpython/rev/cee04627bdd0 -- nosy: +python-dev ___ Python tracker

[issue17099] Raise ValueError when __loader__ not defined for importlib.find_loader()

Changes by Gökcen Eraslan : -- nosy: +gkcn ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue17099] Raise ValueError when __loader__ not defined for importlib.find_loader()

Changes by Ankur Ankan : -- nosy: +Ankur.Ankan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue17099] Raise ValueError when __loader__ not defined for importlib.find_loader()

Eric Snow added the comment: My vote is for making this a ValueError in both cases (and amending the doc appropriately as well). The error amounts to the same thing: the module did not have loader (implicitly or explicitly). If someone wants to distinguish between the two they can explicitly

[issue17099] Raise ValueError when __loader__ not defined for importlib.find_loader()

Changes by Brett Cannon : -- assignee: -> brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue17099] Raise ValueError when __loader__ not defined for importlib.find_loader()

Changes by Eric Snow : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue17099] Raise ValueError when __loader__ not defined for importlib.find_loader()

Changes by Brett Cannon : -- keywords: +easy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue17099] Raise ValueError when __loader__ not defined for importlib.find_loader()

Brett Cannon added the comment: Should mention that this is probably no harder than changing a key getattr() call to None (as pointed out by Nick). -- ___ Python tracker ___ ___

[issue17099] Raise ValueError when __loader__ not defined for importlib.find_loader()

Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue17099] Raise ValueError when __loader__ not defined for importlib.find_loader()

Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue17099] Raise ValueError when __loader__ not defined for importlib.find_loader()

New submission from Brett Cannon: If __loader__ is None then ValueError is raised, but if it is not defined then AttributeError is raised instead. Probably should harmonize around ValueError even in the missing attribute case since __loader__ = None is equivalent to the attribute not existing.