[issue17107] test_sni in test_urllib2net could be enabled

2013-02-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: Ok, I've tweaked the patch a bit and committed it. Thank you! -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed versions: -Python 3.5 ___ Python tracker

[issue17107] test_sni in test_urllib2net could be enabled

2013-02-05 Thread Roundup Robot
Roundup Robot added the comment: New changeset f74a12e23aaa by Antoine Pitrou in branch 'default': Issue #17107: Test client-side SNI support in urllib.request thanks to the new server-side SNI support in the ssl module. http://hg.python.org/cpython/rev/f74a12e23aaa -- nosy: +python-dev

[issue17107] test_sni in test_urllib2net could be enabled

2013-02-04 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thanks for the patch :) Since the test doesn't access a remote host (the version before it was skipped used to), I think it could be moved to test_urllib2_localnet. Also, the transient_internet() shouldn't be necessary. --

[issue17107] test_sni in test_urllib2net could be enabled

2013-02-03 Thread Daniel Black
Daniel Black added the comment: ask and you shall receive :-) -- keywords: +patch nosy: +grooverdan versions: +Python 3.5 Added file: http://bugs.python.org/file28948/https_sni_test.patch ___ Python tracker ___

[issue17107] test_sni in test_urllib2net could be enabled

2013-02-02 Thread Antoine Pitrou
New submission from Antoine Pitrou: Right now test_sni in test_urllib2net is skipped with the message "test disabled - test server needed". But the ssl module now has server-side SNI support, and therefore we could implement this test with a local server (and perhaps move it to test_urllib2_lo