[issue17116] xml.parsers.expat.(errors|model) don't set the __loader__ attribute

Brett Cannon added the comment: New changeset e39a8f8ceb9f by Brett Cannon in branch 'default': #17115,17116: Have modules initialize the __package__ and __loader__ http://hg.python.org/cpython/rev/e39a8f8ceb9f -- resolution: -> fixed stage: -> committed/rejected status: open -> closed

[issue17116] xml.parsers.expat.(errors|model) don't set the __loader__ attribute

Brett Cannon added the comment: The comment is out of date; I removed the test because it was constantly failing. As for the patch, it looks correct, but I plan to make a change to Python so that __loader__ is set by default (see the dependent issue #17115). If I don't get to that change I wi

[issue17116] xml.parsers.expat.(errors|model) don't set the __loader__ attribute

Gökçen Eraslan added the comment: Should this be done in Modules/pyexpat.c file or in Lib/xml/parsers/expat.py? If modifying expat.py is sufficient, then attached simple patch does the job. By the way I couldn't find the test you are referring to. Is it in Lib/test/test_importlib of somewhere

[issue17116] xml.parsers.expat.(errors|model) don't set the __loader__ attribute

Changes by Brett Cannon : -- dependencies: +__loader__ = None should be fine ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue17116] xml.parsers.expat.(errors|model) don't set the __loader__ attribute

Changes by Brett Cannon : -- keywords: +easy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue17116] xml.parsers.expat.(errors|model) don't set the __loader__ attribute

New submission from Brett Cannon: A new test in test_importlib is discovering that pyexpat is creating both its errors and model modules by hand in pyexpat's initialization function. Should at least set __loader__ to None there. -- assignee: brett.cannon messages: 181280 nosy: brett.ca