[issue1712522] urllib.quote throws exception on Unicode URL

Serhiy Storchaka added the comment: Python 2.7 is no longer supported. -- nosy: +serhiy.storchaka resolution: accepted -> out of date status: open -> closed ___ Python tracker

[issue1712522] urllib.quote throws exception on Unicode URL

Changes by Mark Lawrence breamore...@yahoo.co.uk: -- nosy: -BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1712522 ___ ___

[issue1712522] urllib.quote throws exception on Unicode URL

Mark Lawrence added the comment: A lot of work has already been done on this issue. If this is likely to get into 2.7 then fine leave it open, if not can this be closed? -- ___ Python tracker rep...@bugs.python.org

[issue1712522] urllib.quote throws exception on Unicode URL

Senthil Kumaran orsent...@gmail.com added the comment: Reverted the checkin in revision 83045. For the robotparser issue, one of the these two can be adopted. 1. Fix it by decoding the unicode url using utf-8, strict. 2. Catch the KeyError exception and raise a TypeError exception from the

[issue1712522] urllib.quote throws exception on Unicode URL

Matt Giuca matt.gi...@gmail.com added the comment: If you're going the way of option 2, I would strongly advise against relying on the KeyError. The fact that a KeyError is raised by urllib.quote is not part of it's specification, it's a bug/quirk in the implementation (which is now unlikely

[issue1712522] urllib.quote throws exception on Unicode URL

Senthil Kumaran orsent...@gmail.com added the comment: I agree to the points raised by Antoine. Also yesterday in IRC, Eric Smith mentioned that If someone uses these new parameters in 2.7.1 his code may not work with 2.7 (That would obviously be an undesirable behavior). So, it is better to

[issue1712522] urllib.quote throws exception on Unicode URL

Antoine Pitrou pit...@free.fr added the comment: Senthil, have you read my comment on python-checkins? Couldn't this have been fixed without introducing a new API in a bugfix branch? -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org

[issue1712522] urllib.quote throws exception on Unicode URL

Senthil Kumaran orsent...@gmail.com added the comment: I just checked your comment in the checkins list. I saw this is as bug-fix, which was leading to change in the signature of the quote function, still in backward compatible way. Should we still not do it? I understood only feature

[issue1712522] urllib.quote throws exception on Unicode URL

Antoine Pitrou pit...@free.fr added the comment: I understood only feature requests and behavior changes are disallowed in bug-fix branch. Well, isn't it a new feature you're adding? -- ___ Python tracker rep...@bugs.python.org

[issue1712522] urllib.quote throws exception on Unicode URL

Matt Giuca matt.gi...@gmail.com added the comment: From http://mail.python.org/pipermail/python-checkins/2010-July/095350.html: Looking at the issue (which in itself was quite old), you could as well have fixed the robotparser module instead. It isn't an issue with robotparser. The original

[issue1712522] urllib.quote throws exception on Unicode URL

Matt Giuca matt.gi...@gmail.com added the comment: Well, isn't it a new feature you're adding? You had a function which raised a confusing and unintentional KeyError when given non-ASCII Unicode input. Now it doesn't. That's the bug fix part. What I assume you're referring to as a new

[issue1712522] urllib.quote throws exception on Unicode URL

Antoine Pitrou pit...@free.fr added the comment: It's definitely a bug in urllib A bug in what way? Up to 2.6 (*), the docs state nothing about the type of the string parameter. (*) http://docs.python.org/release/2.6.5/library/urllib.html#urllib.quote I think everyone assumed that the

[issue1712522] urllib.quote throws exception on Unicode URL

Senthil Kumaran orsent...@gmail.com added the comment: Well, my understanding was Type:behavior was a bug fix and Type: feature request was a new feature request, which may change some underlying behavior. I thought this issue was on the border. The robotparser using this might be just one

[issue1712522] urllib.quote throws exception on Unicode URL

Antoine Pitrou pit...@free.fr added the comment: Well, my understanding was Type:behavior was a bug fix and Type: feature request was a new feature request, which may change some underlying behavior. I thought this issue was on the border. The original issue is against robotparser, and

[issue1712522] urllib.quote throws exception on Unicode URL

Senthil Kumaran orsent...@gmail.com added the comment: On Mon, Jul 19, 2010 at 11:25:30AM +, Antoine Pitrou wrote: If we were following you, we would add encoding and errors arguments to any str-accepting 2.x function, so that it can also accept unicode strings. That's certainly not a

[issue1712522] urllib.quote throws exception on Unicode URL

Matt Giuca matt.gi...@gmail.com added the comment: I think everyone assumed that the parameter should be a str object and nothing else. Apparently some people used it accidentally with some unicode strings and it worked until these strings contained non-ASCII characters. I don't consider

[issue1712522] urllib.quote throws exception on Unicode URL

Antoine Pitrou pit...@free.fr added the comment: Now one of the major goals of Python 2.6/2.7 is to allow the writing of code which ports smoothly to Python 3. Unicode support is a major issue here. I understand the argument. But 2.7 is a bugfix branch and shouldn't receive new features,

[issue1712522] urllib.quote throws exception on Unicode URL

Antoine Pitrou pit...@free.fr added the comment: Sorry, the email gateway of Roundup ate half of my snippets. Here they are again: zlib.compress(uha) 'x\x9c\xcbH\x04\x00\x013\x00\xca' zlib.compress(uhà) Traceback (most recent call last): File stdin, line 1, in module UnicodeEncodeError:

[issue1712522] urllib.quote throws exception on Unicode URL

Matt Giuca matt.gi...@gmail.com added the comment: OK sure, there are some other things broken, but they are mostly not dealing with string data, but binary data (for example, zlib expects a sequence of bytes, not characters). Just one quick point: urllib.urlretrieve(file:///tmp/hé)

[issue1712522] urllib.quote throws exception on Unicode URL

Senthil Kumaran orsent...@gmail.com added the comment: There are two points here: First, is it a desired behavior of quote function in 2.7? IMO, it is. In the discussions of issue3300, I think, it was decided that quote handling of unicode strings may be backported. Behaviour wise the

[issue1712522] urllib.quote throws exception on Unicode URL

Antoine Pitrou pit...@free.fr added the comment: The forward compatibility on 2.7.1 version here is on the basis that someone in 2.7 might be relying on Exception raised for Unicode string for the quote function. Again, the problem isn't compatibility. It is, simply, that we shouldn't add

[issue1712522] urllib.quote throws exception on Unicode URL

Matt Giuca matt.gi...@gmail.com added the comment: Thanks for doing that, Senthil. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1712522 ___

[issue1712522] urllib.quote throws exception on Unicode URL

Mark Lawrence breamore...@yahoo.co.uk added the comment: I've run an eye over this and don't see any problems, particularly in the light of msg101043. Only 2.7 is affected as the fix has been backported from py3k. Please can we go forward with this. -- nosy: +BreamoreBoy versions:

[issue1712522] urllib.quote throws exception on Unicode URL

Senthil Kumaran orsent...@gmail.com added the comment: Incidentally, I was working on this yeserterday. Some minor changes were required in the patch as quote had undergone changes. Fixed and committed in revision 82940. Thanks to Matt Giuca for this. -- resolution: accepted - fixed

[issue1712522] urllib.quote throws exception on Unicode URL

AdamN a...@varud.com added the comment: Nudge. Somebody with the authority needs to increment the stage to patch review. -- nosy: +adamnelson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1712522

[issue1712522] urllib.quote throws exception on Unicode URL

Changes by Ezio Melotti ezio.melo...@gmail.com: -- stage: unit test needed - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1712522 ___

[issue1712522] urllib.quote throws exception on Unicode URL

Changes by Lino Mastrodomenico l.mastrodomen...@gmail.com: -- nosy: +mastrodomenico ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1712522 ___ ___

[issue1712522] urllib.quote throws exception on Unicode URL

Matt Giuca matt.gi...@gmail.com added the comment: I've finally gotten around to a complete analysis of this code. I have a code/test/documentation patch which fixes the issue without any code breakage. There is another bug in quote which I've found and fixed with this patch: If the 'safe'

[issue1712522] urllib.quote throws exception on Unicode URL

Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1712522 ___ ___

[issue1712522] urllib.quote throws exception on Unicode URL

Changes by Senthil orsent...@gmail.com: -- assignee: - orsenthil resolution: - accepted type: - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1712522 ___

[issue1712522] urllib.quote throws exception on Unicode URL

Matt Giuca matt.gi...@gmail.com added the comment: The issue of urllib.quote was discussed at extreme length in issue 3300, which was specific to Python 3. http://bugs.python.org/issue3300 In the end, I rewrote the entire family of urllib.quote and unquote functions; they're now Unicode

[issue1712522] urllib.quote throws exception on Unicode URL

Changes by Daniel Diniz aja...@gmail.com: -- keywords: +easy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1712522 ___ ___ Python-bugs-list

[issue1712522] urllib.quote throws exception on Unicode URL

John Nagle na...@users.sourceforge.net added the comment: Note that the problem can't be solved by telling end users to call a different quote function. The problem is down inside a library module. robotparser is calling urllib.quote. One of those two library modules needs to be fixed.

[issue1712522] urllib.quote throws exception on Unicode URL

Changes by STINNER Victor victor.stin...@haypocalc.com: -- components: +Unicode nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1712522 ___

[issue1712522] urllib.quote throws exception on Unicode URL

STINNER Victor victor.stin...@haypocalc.com added the comment: quote() works in Python3 with any bytes string (not only ASCII) and any unicode string: Python 3.1a0 (py3k:69105M, Feb 3 2009, 15:04:35) from urllib.parse import quote quote('é') '%C3%A9' quote('\xe9') '%C3%A9'

[issue1712522] urllib.quote throws exception on Unicode URL

Changes by Daniel Diniz aja...@gmail.com: -- nosy: +orsenthil stage: - test needed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1712522 ___ ___

[issue1712522] urllib.quote throws exception on Unicode URL

Daniel Diniz aja...@gmail.com added the comment: IMHO, the TypeError would be a bugfix for 2.6.x. A urllib.quote_unicode could be provided (in 2.7) to match urllib.parse.quote in 3.0 and the OP usecase. I can provide a simple patch, but I'm afraid the OP's remarks about ASCII-range and

[issue1712522] urllib.quote throws exception on Unicode URL

Valery khame...@gmail.com added the comment: Hi, gurus, can anyone then give a hint what we mortals should use in order to form the URL with non-ascii symbols? We loved so much idea to feed our national symbols to urllib.quote as unicode string... and now we are quite disoriented... Thanks

[issue1712522] urllib.quote throws exception on Unicode URL

Valery khame...@gmail.com added the comment: (self-answer to msg78153) the working recipe is: http://www.nabble.com/Re:-Problem:-neither-urllib2.quote-nor- urllib.quote-encode-the--unicode-strings-arguments-p19823144.html ___ Python tracker