[issue17134] Use Windows' certificate store for CA certs

2013-02-05 Thread Christian Heimes
New submission from Christian Heimes: I found a recipe how to access the Windows certificate store and dump its content as PEM. The code doesn't look complicated and could be added to _ssl.c http://fixunix.com/openssl/254866-re-can-openssl-use-windows-certificate-store.html -- componen

[issue17134] Use Windows' certificate store for CA certs

2013-02-05 Thread Christian Heimes
Changes by Christian Heimes : Added file: http://bugs.python.org/file28964/certstore.cpp ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue17134] Use Windows' certificate store for CA certs

2013-02-05 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue17134] Use Windows' certificate store for CA certs

2013-02-05 Thread Éric Araujo
Éric Araujo added the comment: Isn’t this part of #13655? One feature is usually discussed for all platforms in one bug report. (Sorry for all the bureaucracy in your recent reports, but it helps keep things manageable :) -- nosy: +eric.araujo ___

[issue17134] Use Windows' certificate store for CA certs

2013-02-05 Thread Christian Heimes
Christian Heimes added the comment: I like to split up tasks in small subtasks. It's true that #13655 benefits from this feature but it can be implemented without this ticket. This enhancement also requires some addition to API and bindings to Windows' crypt32.dll. It might be inappropriate to

[issue17134] Use Windows' certificate store for CA certs

2013-02-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: Sounds promising. Do you think this should be hooked into SSLContext.set_default_verify_paths, or be exposed as a separate method? -- ___ Python tracker __

[issue17134] Use Windows' certificate store for CA certs

2013-06-07 Thread Jean-Paul Calderone
Jean-Paul Calderone added the comment: > Sounds promising. Do you think this should be hooked into > SSLContext.set_default_verify_paths, or be exposed as a separate method? If there were an API which exposed the certificate material, then this would be more useful to libraries trying to do ot

[issue17134] Use Windows' certificate store for CA certs

2013-06-07 Thread Christian Heimes
Christian Heimes added the comment: Yes, I'm planing to expose the low level API. I prefer to do as much work in Python space as possible. The information is just too useful to 3rd parties, too. I'm thinking about one low level function that interfaces Windows's cert store. The rest can be bu

[issue17134] Use Windows' certificate store for CA certs

2013-06-07 Thread Christian Heimes
Christian Heimes added the comment: First patch. I have not yet verified that the return data can be loaded by openssl. Also I need to verify the error paths and add some tests, too. -- keywords: +patch stage: needs patch -> patch review Added file: http://bugs.python.org/file30497/enum

[issue17134] Use Windows' certificate store for CA certs

2013-06-07 Thread Christian Heimes
Christian Heimes added the comment: I fixed a ref leak and added some tests. -- Added file: http://bugs.python.org/file30500/enumcertstore2.patch ___ Python tracker ___ _

[issue17134] Use Windows' certificate store for CA certs

2013-06-08 Thread Christian Heimes
Christian Heimes added the comment: New patch with fixed doc string and indention. http://msdn.microsoft.com/en-us/library/windows/desktop/aa377189%28v=vs.85%29.aspx explains how encoding type shall be interpreted. I haven't seen PKCS#7 certs on my Windows system, though. Instead of a flag I

[issue17134] Use Windows' certificate store for CA certs

2013-06-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 10d325f674f5 by Christian Heimes in branch 'default': Issue #17134: Add ssl.enum_cert_store() as interface to Windows' cert store. http://hg.python.org/cpython/rev/10d325f674f5 -- nosy: +python-dev ___ Py

[issue17134] Use Windows' certificate store for CA certs

2013-06-09 Thread Antoine Pitrou
Antoine Pitrou added the comment: > New changeset 10d325f674f5 by Christian Heimes in branch 'default': > Issue #17134: Add ssl.enum_cert_store() as interface to Windows' cert store. > http://hg.python.org/cpython/rev/10d325f674f5 I don't want to sound annoying, but I would have liked to review

[issue17134] Use Windows' certificate store for CA certs

2013-06-10 Thread Christian Heimes
Christian Heimes added the comment: Ezio already reviewed my code. But sure I can wait a couple of days. The second part of the patch depends on #18138 anyway. -- ___ Python tracker ___