[issue17289] readline.set_completer_delims() doesn't play well with others

2013-02-24 Thread Bradley Froehle
New submission from Bradley Froehle: The `readline.set_completer_delims` doesn't play well with others because it assumes that only it ever allocates or modifies the rl_completer_word_break_characters buffer. If other programs modify this value, for example changing it from heap allocated space

[issue17289] readline.set_completer_delims() doesn't play well with others

2013-02-25 Thread Thomas Kluyver
Changes by Thomas Kluyver : -- nosy: +takluyver ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue17289] readline.set_completer_delims() doesn't play well with others

2013-02-25 Thread Christoph Gohlke
Changes by Christoph Gohlke : -- nosy: +cgohlke ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue17289] readline.set_completer_delims() doesn't play well with others

2013-05-04 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thanks for reporting this. Do you want to contribute a proper patch? You'll find instructions at http://docs.python.org/devguide/ -- nosy: +pitrou stage: -> needs patch versions: -Python 3.2 ___ Python tracker

[issue17289] readline.set_completer_delims() doesn't play well with others

2013-05-05 Thread Bradley Froehle
Bradley Froehle added the comment: Patch attached. I implemented this by adding a 'static char *' which holds the memory we allocate. I did not use the PyState machinery. -- keywords: +patch Added file: http://bugs.python.org/file30143/readline_completer_state.patch

[issue17289] readline.set_completer_delims() doesn't play well with others

2013-05-06 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue17289] readline.set_completer_delims() doesn't play well with others

2013-05-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 55c7295aca6c by Antoine Pitrou in branch '2.7': Issue #17289: The readline module now plays nicer with external modules or applications changing the rl_completer_word_break_characters global variable. http://hg.python.org/cpython/rev/55c7295aca6c -

[issue17289] readline.set_completer_delims() doesn't play well with others

2013-05-06 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thanks for the patch! I made a variable name a bit shorter and also added some error checking on the strdup() result. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Pyth

[issue17289] readline.set_completer_delims() doesn't play well with others

2013-05-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset df0afd3ebb70 by Antoine Pitrou in branch '3.3': Issue #17289: The readline module now plays nicer with external modules or applications changing the rl_completer_word_break_characters global variable. http://hg.python.org/cpython/rev/df0afd3ebb70 N