[issue17293] uuid.getnode() MAC address on AIX

Dimitri John Ledkov added the comment: I'm getting socket.gaierror from test_ifconfig_getnode / uuid._ifconfig_getnode() on python 3.4.2 on Linux, in a no network environment. Thus i'd like to see these try:/excepts: to be ported back to 3.4 branch, if they haven't been already. I filed http:

[issue17293] uuid.getnode() MAC address on AIX

Changes by Serhiy Storchaka : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue17293] uuid.getnode() MAC address on AIX

Roundup Robot added the comment: New changeset 301d62ef5c0b by Serhiy Storchaka in branch '2.7': Issue #17293: socket.gethostbyname() can raise an exception of FreeBSD. https://hg.python.org/cpython/rev/301d62ef5c0b New changeset 97ceab0bd6f8 by Serhiy Storchaka in branch '3.4': Issue #17293: so

[issue17293] uuid.getnode() MAC address on AIX

koobs added the comment: I don't have the environment to test here. Can you run a custom build on the buildbots? -- ___ Python tracker ___ __

[issue17293] uuid.getnode() MAC address on AIX

Serhiy Storchaka added the comment: Oh, socket.gaierror was not made an alias of OSError, only subclass of it. Well, we can apply the same patch to all releases. Does it fix tests? -- ___ Python tracker __

[issue17293] uuid.getnode() MAC address on AIX

koobs added the comment: I only attached the 2.7 build log because the failures from 3.4 and 3.x are identical, copying them here for completeness: >From 3.4: == ERROR: test_arp_getnode (test.test_uuid.TestUUID) -

[issue17293] uuid.getnode() MAC address on AIX

Serhiy Storchaka added the comment: This issue had added new tests. Here is a patch against 2.7 (3.4+ should use OSError instead of socket.gaierror) which fixes _arp_getnode(). -- Added file: http://bugs.python.org/file37196/uuid_arp_getnode_freebsd.patch __

[issue17293] uuid.getnode() MAC address on AIX

koobs added the comment: koobs-freebsd10 buildbot broken on all branches since: 2.7: e80cb046e7641fb8a71dda8254d2e619cdd64480 3.4: ba4b31ed2952b65ca447f57fbd6d540ebc4b749c 3.x: 3e4f3cc4f1f9dbee8e0ed5df47f77baae2ad310c Full (2.7) log attached. ===

[issue17293] uuid.getnode() MAC address on AIX

Serhiy Storchaka added the comment: Looks as this hasn't broke buildbots. Thank you Aivars for your patch. Thank you Natali and Victor for your suggestions and reviews. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue17293] uuid.getnode() MAC address on AIX

Roundup Robot added the comment: New changeset e80cb046e764 by Serhiy Storchaka in branch '2.7': Issue #17293: uuid.getnode() now determines MAC address on AIX using netstat. https://hg.python.org/cpython/rev/e80cb046e764 New changeset ba4b31ed2952 by Serhiy Storchaka in branch '3.4': Issue #172

[issue17293] uuid.getnode() MAC address on AIX

Serhiy Storchaka added the comment: Here are updated patches for 3.5 (using subprocess) and 3.4 (using os.popen) which addresses Victor's comments. -- Added file: http://bugs.python.org/file36998/uuid_netstat_getnode-3.5_2.patch Added file: http://bugs.python.org/file36999/uuid_netstat_

[issue17293] uuid.getnode() MAC address on AIX

Serhiy Storchaka added the comment: > You probably forgot to attach the patch... Indeed. :-( -- Added file: http://bugs.python.org/file36993/uuid_netstat_getnode-3.5.patch ___ Python tracker __

[issue17293] uuid.getnode() MAC address on AIX

STINNER Victor added the comment: > Here is a patch for 3.5 which uses subprocess.Popen() (subprocess.Popen() > used in _find_mac() since issue22637). You probably forgot to attach the patch... -- ___ Python tracker

[issue17293] uuid.getnode() MAC address on AIX

Serhiy Storchaka added the comment: Here is a patch for 3.5 which uses subprocess.Popen() (subprocess.Popen() used in _find_mac() since issue22637). -- ___ Python tracker ___ __

[issue17293] uuid.getnode() MAC address on AIX

Serhiy Storchaka added the comment: > The code you *add in this patch* uses os.popen, why not use subprocess > instead? Added code is just modified copy of existing code. > Furthermore, the code catches OSError when calling popen(), but popen() doesn't raise an exception. It can raise an exce

[issue17293] uuid.getnode() MAC address on AIX

STINNER Victor added the comment: +cmd = 'LC_ALL=C %s %s 2>/dev/null' % (executable, '-ia') It's safer to use the subprocess module instead of using a shell (see the recent Shellshock story) to change the environment variables and to redirect stderr. subprocess now has a convinient subproc

[issue17293] uuid.getnode() MAC address on AIX

STINNER Victor added the comment: FYI os.popen() now calls subprocess... So it's safe to call directly subprocess. -- nosy: +haypo ___ Python tracker ___

[issue17293] uuid.getnode() MAC address on AIX

Charles-François Natali added the comment: Why is that a different issue? The code you *add in this patch* uses os.popen, why not use subprocess instead? Furthermore, the code catches OSError when calling popen(), but popen() doesn't raise an exception. -- _

[issue17293] uuid.getnode() MAC address on AIX

Serhiy Storchaka added the comment: This is different issue and can be applied only to 3.5. -- ___ Python tracker ___ ___ Python-bugs-

[issue17293] uuid.getnode() MAC address on AIX

Charles-François Natali added the comment: My only comment would be to use subprocess instead of os.popen(). -- ___ Python tracker ___ ___

[issue17293] uuid.getnode() MAC address on AIX

Serhiy Storchaka added the comment: If there are no objections, I'll commit the patch soon. -- ___ Python tracker ___ ___ Python-bugs-

[issue17293] uuid.getnode() MAC address on AIX

Serhiy Storchaka added the comment: Thank you Aivars for your patch. I have verified and confirm that this method works on AIX and True64 UNIX (it should also work on IRIX, but I can't login in Snakebite's i6). Here is modified patch. MAC address is now searched only in column with the "Addre

[issue17293] uuid.getnode() MAC address on AIX

Mark Lawrence added the comment: David is listed against AIX on the experts list https://docs.python.org/devguide/experts.html. That alone suggests to me that AIX is an officially supported platform. -- ___ Python tracker

[issue17293] uuid.getnode() MAC address on AIX

Charles-François Natali added the comment: > Huh? What does officially supported platform mean? CPython builds and runs > on AIX. It means a platform for which we have regular contributors committed to support the port, and ideallly with a stable buildbot. We apparently have an unstable build

[issue17293] uuid.getnode() MAC address on AIX

David Edelsohn added the comment: Huh? What does officially supported platform mean? CPython builds and runs on AIX. -- ___ Python tracker ___ _

[issue17293] uuid.getnode() MAC address on AIX

Charles-François Natali added the comment: Thanks for the patch, but I'm not even sure AIX is an officially supported platform, so I'm not sure what to do with this patch. -- nosy: +neologix ___ Python tracker ___

[issue17293] uuid.getnode() MAC address on AIX

Mark Lawrence added the comment: @Aivars sorry about the delay in getting back to you. -- nosy: +BreamoreBoy, David.Edelsohn type: -> behavior versions: +Python 3.4, Python 3.5 -Python 2.6 ___ Python tracker _

[issue17293] uuid.getnode() MAC address on AIX

New submission from Aivars Kalvāns: uuid.getnode() on AIX returned random integer. This patch finds MAC in output of `netstat -ia`. Tested on AIX 5.2 -- components: Library (Lib) files: aix_mac.patch keywords: patch messages: 182925 nosy: aivarsk priority: normal severity: normal status