[issue17313] test_logging doesn't clean up after itself

2013-02-27 Thread Chris Jerdonek
New submission from Chris Jerdonek: test_logging leaves behind a file called test.log in the current working directory. I haven't narrowed down to the specific test, and I'm not sure what other versions are affected. -- components: Tests messages: 183176 nosy: chris.jerdonek,

[issue17313] test_logging doesn't clean up after itself

2013-02-27 Thread Vinay Sajip
Vinay Sajip added the comment: There are only three logging tests that open a handler to test.log: test_filename, test_filemode and test_incompatible. AFAIK those tests have remained unchanged over several years, if not months. Is the failure repeatable? Which platform did the failure occur

[issue17313] test_logging doesn't clean up after itself

2013-02-27 Thread Vinay Sajip
Vinay Sajip added the comment: I investigated a little further. The file is created in the test directory (build/test_python_/) and, I assume, the dir is wiped at the end of the test. I can go through and do an addCleanup(os.remove, 'test.log') in the relevant tests; that should do it.

[issue17313] test_logging doesn't clean up after itself

2013-02-27 Thread Chris Jerdonek
Chris Jerdonek added the comment: Thanks for investigating. Yes, currently regrtest.py deletes the containing directory. But this doesn't happen when running with plain unittest. If each test cleans up after itself, this will give us more flexibility in moving from regrtest to a

[issue17313] test_logging doesn't clean up after itself

2013-02-27 Thread Roundup Robot
Roundup Robot added the comment: New changeset b7f5bff33c22 by Vinay Sajip in branch 'default': Closes #17313: Deleted test file created by test_logging. http://hg.python.org/cpython/rev/b7f5bff33c22 -- nosy: +python-dev resolution: - fixed stage: needs patch - committed/rejected