[issue17317] Benchmark driver should calculate actual benchmark count in -h

Brett Cannon added the comment: Thanks for being so patient, Anuj! -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue17317] Benchmark driver should calculate actual benchmark count in -h

Roundup Robot added the comment: New changeset 3be9e07a2df4 by Brett Cannon in branch 'default': Issue #17317: Have the benchmark count from -h properly reflect the http://hg.python.org/benchmarks/rev/3be9e07a2df4 -- nosy: +python-dev ___ Python track

[issue17317] Benchmark driver should calculate actual benchmark count in -h

Anuj Gupta added the comment: The asterisk is visible now, Brett :) Please commit the patch at your convenience. -- ___ Python tracker ___ __

[issue17317] Benchmark driver should calculate actual benchmark count in -h

Brett Cannon added the comment: The asterisk is added manually by a person, so by virtue of it being a weekend no one has gotten to it yet. As soon as it has been processed and I have time I will commit the patch. -- ___ Python tracker

[issue17317] Benchmark driver should calculate actual benchmark count in -h

Anuj Gupta added the comment: I did it yesterday while studying the devguide and "how to get started" articles. Just did it again, and received an email with the subject "The Python Contributor Agreement Form (between Anuj Gupta and Python Software Foundation) is Signed and Filed!". Still no

[issue17317] Benchmark driver should calculate actual benchmark count in -h

Brett Cannon added the comment: How and when did you sign the CLA? It has not been registered yet that you have, else your username would have an asterisk next to it. As for Misc/ACKS, that's in Python itself and not the benchmark suite so this wouldn't get you in that file. To contribute mor

[issue17317] Benchmark driver should calculate actual benchmark count in -h

Anuj Gupta added the comment: Improved wording of the comment -- Added file: http://bugs.python.org/file29367/benchmark_count.patch ___ Python tracker ___ ___

[issue17317] Benchmark driver should calculate actual benchmark count in -h

Anuj Gupta added the comment: I've already signed that. I was contemplating adding my name to the Misc/ACK file but I'd like to know if it's appropriate. Certainly gives one a confidence boost, but I'm not aware whether this fix qualifies me for it. I'd like to contribute a lot more code to Py

[issue17317] Benchmark driver should calculate actual benchmark count in -h

Brett Cannon added the comment: Thanks for the patch, Anuj! The solution looks fine. While reviewing I discovered the test suite didn't work anymore and so I fixed that plus added a test to the name expansion to make sure it would always work properly. All of that is included in the patch I up

[issue17317] Benchmark driver should calculate actual benchmark count in -h

Anuj Gupta added the comment: Fixed ( My first contribution ever, please be kind :) ) -- keywords: +patch nosy: +anuj type: -> behavior Added file: http://bugs.python.org/file29361/benchmark_count.patch ___ Python tracker

[issue17317] Benchmark driver should calculate actual benchmark count in -h

New submission from Brett Cannon: E.g. when you run ``./perf.py -h`` it lists the py3k benchmark target as having 4 benchmarks, but that's wrong since the 2n3 benchmark alone (which py3k includes) has 23 benchmarks. -- keywords: easy messages: 183183 nosy: brett.cannon priority: normal