[issue17346] Pickle tests do not test protocols 0, 1, and 2 for bytes

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: Fixed, thanks for the report and the patch! -- assignee: -> ezio.melotti resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker __

[issue17346] Pickle tests do not test protocols 0, 1, and 2 for bytes

2013-03-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset a982feb29584 by Ezio Melotti in branch '3.2': #17346: make sure pickle tests are run against all protocols. Initial patch by Marius Gedminas. http://hg.python.org/cpython/rev/a982feb29584 New changeset 796de4f7df07 by Ezio Melotti in branch '3.3':

[issue17346] Pickle tests do not test protocols 0, 1, and 2 for bytes

2013-03-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. -- nosy: +serhiy.storchaka versions: +Python 3.2, Python 3.4 ___ Python tracker ___ ___ Pyth

[issue17346] Pickle tests do not test protocols 0, 1, and 2 for bytes

2013-03-04 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue17346] Pickle tests do not test protocols 0, 1, and 2 for bytes

2013-03-04 Thread Marius Gedminas
New submission from Marius Gedminas: I was reading Lib/test/pickletester.py when I noticed that test_bytes loops over all the protocols but doesn't actually use the loop variable anywhere. Attached patch should fix this. -- components: Tests files: actually-test-all-protocols.diff keyw