[issue17396] modulefinder fails if module contains syntax error

Nick Coghlan added the comment: Fixed for Python 3.8 via the patch for #35936. We won't be backporting that patch as it also migrates modulefinder from the deprecated imp API to support importlib one, and is hence considered overly intrusive for a bug fix release. -- resolution: ->

[issue17396] modulefinder fails if module contains syntax error

Change by Brandt Bucher : -- pull_requests: +11781, 11782, 11783, 11784 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue17396] modulefinder fails if module contains syntax error

Change by Brandt Bucher : -- pull_requests: +11781, 11782, 11783 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue17396] modulefinder fails if module contains syntax error

Change by Brandt Bucher : -- pull_requests: +11781, 11782 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17396] modulefinder fails if module contains syntax error

Change by Brandt Bucher : -- pull_requests: +11781 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17396] modulefinder fails if module contains syntax error

Changes by Berker Peksag berker.pek...@gmail.com: -- nosy: +berker.peksag stage: - patch review type: - behavior versions: +Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17396

[issue17396] modulefinder fails if module contains syntax error

Jan Gosmann added the comment: Here is an updated patch, also containing a test. -- Added file: http://bugs.python.org/file30237/fix-handling-of-syntax-errors.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17396

[issue17396] modulefinder fails if module contains syntax error

Jan Gosmann added the comment: It's based on the default branch becoming 3.4. -- versions: +Python 3.4 -Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17396 ___

[issue17396] modulefinder fails if module contains syntax error

Éric Araujo added the comment: Thanks for the report and patch. Could you add a test? I’m not sure where this sits on the bug vs. feature line. -- nosy: +eric.araujo, r.david.murray ___ Python tracker rep...@bugs.python.org

[issue17396] modulefinder fails if module contains syntax error

Jan Gosmann added the comment: Could you point me to some documentation on how to add a test? I have not been involved in Python development so far. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17396

[issue17396] modulefinder fails if module contains syntax error

Changes by Florent Xicluna florent.xicl...@gmail.com: -- nosy: +flox ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17396 ___ ___ Python-bugs-list

[issue17396] modulefinder fails if module contains syntax error

Éric Araujo added the comment: Certainly: http://docs.python.org/devguide contains information to get the source code, describes the files layout and explains how to generate a patch. You’ll find existing unit tests in Lib/test/test_modulefinder.py Feel free to ask any question you might

[issue17396] modulefinder fails if module contains syntax error

Éric Araujo added the comment: I would recommend that you base your patch on the default branch, i.e. what will become Python 3.4. If we judge that this is not a new feature but actually a bug fix, the core developer who commits the patch will take care of backporting it to 2.7 and 3.3.

[issue17396] modulefinder fails if module contains syntax error

New submission from Jan Gosmann: Running modulefinder.ModuleFinder.run_script on a script which has an import statement with a module containing a syntax error will raise a SyntaxError exception. I think, modulefinder should instead continue its analysis and add the module to badmodules.