[issue1740] use unittest for test_logging

Brett Cannon added the comment: Oh, and thanks Thomas for the port change. I made sure to keep it. __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list

[issue1740] use unittest for test_logging

Brett Cannon added the comment: Committed in r61189 on the trunk. Thanks, Antoine! -- status: open -> closed __ Tracker <[EMAIL PROTECTED]> __ _

[issue1740] use unittest for test_logging

Christian Heimes added the comment: Thomas Herve wrote: > I have just one comment: I have recently modified the initialization of > LogRecordSocketReceiver to not use a stupid loop to get a free port, but > instead use port 0 and get the port number once bound. I think this > modification should

[issue1740] use unittest for test_logging

Thomas Herve added the comment: I have just one comment: I have recently modified the initialization of LogRecordSocketReceiver to not use a stupid loop to get a free port, but instead use port 0 and get the port number once bound. I think this modification should stay. -- nosy: +therve

[issue1740] use unittest for test_logging

Brett Cannon added the comment: On Mon, Feb 25, 2008 at 11:39 AM, Antoine Pitrou <[EMAIL PROTECTED]> wrote: > > Antoine Pitrou added the comment: > > Out of curiosity, what were the PEP 8 violations? Usually I try to > respect the coding guidelines. There were three that pervaded the code. 1

[issue1740] use unittest for test_logging

Antoine Pitrou added the comment: Out of curiosity, what were the PEP 8 violations? Usually I try to respect the coding guidelines. __ Tracker <[EMAIL PROTECTED]> __ ___

[issue1740] use unittest for test_logging

Brett Cannon added the comment: I am attaching a reviewed version of the patch. It had some major PEP 8 violations that I had to clean up. I also moved over to the usage of test.test_support.captured_stdout(). Otherwise it looks good. I am going to wait a little while in hopes someone else can a

[issue1740] use unittest for test_logging

Antoine Pitrou added the comment: Here is an updated patch, it should apply fine against trunk. Added file: http://bugs.python.org/file9522/logtest2.patch __ Tracker <[EMAIL PROTECTED]> __ ___

[issue1740] use unittest for test_logging

Brett Cannon added the comment: Yeah, that's my fault. I forgot to search the issue tracker first before committing the GHOP rewrite. I will do a review of this patch and see which version is better. -- assignee: -> brett.cannon nosy: +brett.cannon __ T

[issue1740] use unittest for test_logging

Antoine Pitrou added the comment: Hmm, apparently another patch was committed in rev 60872. __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailin

[issue1740] use unittest for test_logging

Antoine Pitrou added the comment: Ok here is an updated patch with slightly more complete setUp/tearDown semantics. I don't backup all the objects though since some of them (e.g. _loggerClass) aren't touched by the tests. Added file: http://bugs.python.org/file9074/logtest.patch ___

[issue1740] use unittest for test_logging

Christian Heimes added the comment: Thanks! :) I quick review hasn't shown any larger issues but it need a proper review before it can be submitted. You probably should save _levelNames, _loggerClass, root, Logger.root and Logger.manager in setUp and reset the objects in tearDown. -- k

[issue1740] use unittest for test_logging

New submission from Antoine Pitrou: Lib/test.test_logging.py doesn't use unittest. Here is a patch (against SVN trunk) to fix the problem. -- components: Tests files: logtest.patch messages: 59348 nosy: pitrou severity: normal status: open title: use unittest for test_logging versions: P