[issue17487] wave.Wave_read.getparams should be more user friendly

Roundup Robot added the comment: New changeset a14ec46de0a4 by Serhiy Storchaka in branch 'default': Issue #17487: The result of the wave getparams method now is pickleable again. http://hg.python.org/cpython/rev/a14ec46de0a4 -- ___ Python tracker

[issue17487] wave.Wave_read.getparams should be more user friendly

Serhiy Storchaka added the comment: Thank you Claudiu. I have changed _Wave_params to _wave_params for consistency with issue17818 and issue18901. -- stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue17487] wave.Wave_read.getparams should be more user friendly

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka nosy: +serhiy.storchaka stage: committed/rejected -> patch review ___ Python tracker ___ _

[issue17487] wave.Wave_read.getparams should be more user friendly

Changes by Claudiu.Popa : -- status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue17487] wave.Wave_read.getparams should be more user friendly

Claudiu.Popa added the comment: There is a regression with the latest patch, `getparams` output is no longer picklable. The attached patch fixes this issue. Also, I renamed the internal namedtuple to something more meaningful. -- Added file: http://bugs.python.org/file30245/wave_pickla

[issue17487] wave.Wave_read.getparams should be more user friendly

R. David Murray added the comment: Thanks, Claudiu. -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue17487] wave.Wave_read.getparams should be more user friendly

Roundup Robot added the comment: New changeset 340a12c18b7f by R David Murray in branch 'default': #17487: wave.getparams now returns a namedtuple. http://hg.python.org/cpython/rev/340a12c18b7f -- nosy: +python-dev ___ Python tracker

[issue17487] wave.Wave_read.getparams should be more user friendly

Claudiu.Popa added the comment: Hello. I received the confirmation for my CLA, could you commit the patch? Thank you! -- ___ Python tracker ___ _

[issue17487] wave.Wave_read.getparams should be more user friendly

R. David Murray added the comment: Claudiu: that's the entire process. Now we just wait a day or two until the confirmation arrives from the PSF that they have accepted it (you'll get an '*' next to your name here in the tracker when that happens). --

[issue17487] wave.Wave_read.getparams should be more user friendly

Benjamin Peterson added the comment: Wrong issue, sorry. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue17487] wave.Wave_read.getparams should be more user friendly

Benjamin Peterson added the comment: I backed it out until it can be done without breaking OSX. d174cb3f5b9e -- nosy: +benjamin.peterson ___ Python tracker ___ __

[issue17487] wave.Wave_read.getparams should be more user friendly

Claudiu.Popa added the comment: Hello, I signed the electronic contributor agreement (I received a mail with the final copy afterwards). Is there something else that I should do or that is the entire process? -- ___ Python tracker

[issue17487] wave.Wave_read.getparams should be more user friendly

R. David Murray added the comment: It should. Here's the patch I am prepared to commit once Claudio's contributor for confirmation occurs. -- Added file: http://bugs.python.org/file29542/wave_with_docs.patch ___ Python tracker

[issue17487] wave.Wave_read.getparams should be more user friendly

Berker Peksag added the comment: Should the documentation of the wave module be updated to match this change? See issue 16808 for example. The current wave.Wave_read.getparams documentation says: "Returns a tuple (nchannels, sampwidth, framerate, nframes, comptype, compname), equivalent to ou

[issue17487] wave.Wave_read.getparams should be more user friendly

R. David Murray added the comment: Looks good. Claudio, could you please submit a contributor agreement? (http:://www.python.org/psf/contrib). -- stage: -> commit review ___ Python tracker __

[issue17487] wave.Wave_read.getparams should be more user friendly

Popa Claudiu added the comment: Updated the patch with test for .getparams. -- Added file: http://bugs.python.org/file29499/wave_17487.patch ___ Python tracker ___ __

[issue17487] wave.Wave_read.getparams should be more user friendly

R. David Murray added the comment: This seems like a reasonable idea to me, thanks for the patch. Adding tests for getparams would be a good thing ;) -- nosy: +r.david.murray versions: -Python 3.3 ___ Python tracker

[issue17487] wave.Wave_read.getparams should be more user friendly

New submission from Popa Claudiu: wave.Wave_read/Wave_write.getparams returns a tuple with various info about the wav file, when it could return a namedtuple, that can be manipulated in a richer way. I attached a patch. It doesn't have any tests, mainly because .getparams isn't tested at all i